Activity hdfirmware/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 26 Aug 2022

3:04 pm

Dara Navaei

More
c1fb1a7
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 317 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

3:04 pm

Dara Navaei

More
df4242f
changed 4 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 317 more HD-DEN-13460-2

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -2
- +2
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -2
- +2
/firmware/App/Modes/ModePreTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.h
- -2
- +2
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

3:03 pm

Michael Garthwaite

More
259ced3
changed 0 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 317 more

Merge branch 'DEN-12609-sw_dev-sprint-69_mg' into staging

3:02 pm

Michael Garthwaite

More
HD-DEN-12609-2
Closed

2:59 pm

Dara Navaei and Sean Nash

More
HD-DEN-12609-2
finished reviewing

2:47 pm

Dong Nguyen <dnguyen@diality.com>

More
e54806d
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 315 more HD-DEN-13598-2

DEN-13598 Add code fornew alarms.

- -128
- +82
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -1
- +1
/firmware/App/Controllers/DGInterface.h
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.h
- -2
- +1
/firmware/App/Controllers/Temperatures.c
- History
- Source
- Diff
/firmware/App/Controllers/Temperatures.c
- -3
- +2
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c
- -6
- +0
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c
- -0
- +2
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c
- -0
- +2
/firmware/source/sys_main.c
- History
- Source
- Diff
/firmware/source/sys_main.c

2:16 pm

Michael Garthwaite

More
b6e15b3
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 318 more HD-DEN-12609-2

Merge branch 'staging' into DEN-12609-sw_dev-sprint-69_mg

- -3
- +3
/firmware/App/Modes/Prime.c
- History
- Source
- Diff
/firmware/App/Modes/Prime.c

2:14 pm

dcox (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

dcox (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

dcox (deleted user)

More
Re: HD-DEN-12609-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

More
Re: HD-DEN-12609-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

More
Re: HD-DEN-12609-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:40 pm

Dong Nguyen <dnguyen@diality.com>

More
25b2545
changed 0 files
develop

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

1:30 pm

Dara Navaei

More
31e819c
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

1:29 pm

Dara Navaei

More
2a17e8b
changed 1 file
develop

Turned off simulate UI

- -1
- +1
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h

11:58 am

dcox (deleted user)

More
Re: HD-DEN-13598-2
commented on review

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

11:56 am

dcox (deleted user)

More
Re: HD-DEN-13598-2
commented on review

Uncomment or add a comment explaining why it is inactive.

Uncomment or add a comment explaining why it is inactive.

11:55 am

dcox (deleted user)

More
Re: HD-DEN-13598-2
commented on review

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

10:19 am

Michael Garthwaite

More
Re: HD-DEN-12609-2
replied to Sean Nash

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

10:14 am

Michael Garthwaite

More
Re: HD-DEN-12609-2
replied to Sean Nash

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

More
Re: HD-DEN-12609-2
replied to Sean Nash

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

10:13 am

Michael Garthwaite

More
a113279
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-12609-sw_dev-sprint-69_mg and 318 more HD-DEN-12609-2

code review changes

- -13
- +5
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c

Thursday 25 Aug 2022

6:10 pm

Dara Navaei

More
HD-DEN-13598-2
started review

HD-DEN-13598_DG HD Dev Sprint 77 FW Dong

HD-DEN-13598_DG HD Dev Sprint 77 FW Dong

5:10 pm

Dara Navaei

More
HD-DEN-13460-2
started review

HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2

HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2

4:40 pm

Sean Nash

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 13:27 -0700