hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Sep 2022
10:46 am

Dara Navaei

DEN-13834 added the DG heaters broadcast message. Addded a function to check the status of the trimmer heater's state in DGInterface and keep sending the command from HD until the trimmer heater is in the right status. Enabled stop/start trimmer command in the modes

Options
    • -1
    • +41
    /firmware/App/Controllers/DGInterface.c
    • -29
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -10
    • +0
    /firmware/App/Controllers/DialOutFlow.h
    • -1
    • +1
    /firmware/App/Modes/BloodPrime.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -4
    • +23
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +4
    /firmware/App/Services/SystemCommMessages.h
Friday 02 Sep 2022
4:27 pm

Sean Nash

I think the style is to use set/get functions if needed by other modules, otherwise just access the variable directly.

I think the style is to use set/get functions if needed by other modules, otherwise just access the variable directly.

4:20 pm

Sean Nash

Need to initialize here at declaration or in init function. I see neither now.

Need to initialize here at declaration or in init function. I see neither now.

Thursday 01 Sep 2022
4:52 pm

Dara Navaei

DEN-13460 addressed the code review comments

Options
    • -29
    • +31
    /firmware/App/Controllers/BloodLeak.c
    • -11
    • +11
    /firmware/App/Controllers/DGInterface.c
    • -2
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +2
    /firmware/App/Controllers/DialOutFlow.c
    • -3
    • +5
    /firmware/App/Controllers/PresOccl.c
    • -3
    • +2
    /firmware/App/Controllers/SyringePump.c
    • -7
    • +6
    /firmware/App/Controllers/Temperatures.c
    • -5
    • +5
    /firmware/App/Controllers/Valves.c
    • -5
    • +5
    /firmware/App/Drivers/Battery.c
    • -1
    • +1
    /firmware/App/Modes/BloodPrime.c
    • -4
    • +4
    /firmware/App/Modes/ModeFault.c
    • -4
    • +4
    /firmware/App/Modes/SelfTests.c
    • -3
    • +3
    /firmware/App/Services/AlarmMgmt.c
    • -7
    • +5
    /firmware/App/Services/Reservoirs.c
    • -5
    • +6
    /firmware/App/Services/SystemComm.c
4:37 pm

Dara Navaei

Thanks for the reminder.

Thanks for the reminder.

4:36 pm

Dara Navaei

Done.

Done.

4:35 pm

Dara Navaei

Done.

Done.

4:34 pm

Dara Navaei

Done.

Done.

4:33 pm

Dara Navaei

Done.

Done.

4:31 pm

Dara Navaei

Done.

Done.

4:29 pm

Dara Navaei

Done.

Done.

4:29 pm

Dara Navaei

Done.

Done.

2:39 pm

Michael Garthwaite

More of a caution than an explicit fix. Dong's S77 branch has some of the changes that are reflected here. He also has the more recent commit. Be careful when both of you merge your branches.

More of a caution than an explicit fix. Dong's S77 branch has some of the changes that are reflected here. He also has the more recent commit. Be careful when both of you merge your branches.

2:33 pm

Michael Garthwaite

remove blank line

remove blank line

11:33 am

Dara Navaei

Done.

Done.

10:35 am

Dara Navaei

Done.

Done.

10:25 am

Dara Navaei

Done.

Done.

10:17 am

Dara Navaei

Done.

Done.

10:15 am

Dara Navaei

Done.

Done.

10:14 am

Dara Navaei

Done.

Done.

10:13 am

Dara Navaei

Done.

Done.

10:12 am

Dara Navaei

Done.

Done.

10:11 am

Dara Navaei

Done.

Done.

10:09 am

Dara Navaei

Done.

Done.

10:08 am

Dara Navaei

Done.

Done.

9:37 am

Sean Nash

I think we want to see more than this here to pass this phase of test.

I think we want to see more than this here to pass this phase of test.

9:34 am

Dara Navaei

Done.

Done.

9:27 am

Dara Navaei

Done.

Done.

Wednesday 31 Aug 2022
9:41 pm

Dara Navaei

Done.

Done.

9:39 pm

Dara Navaei

Done.

Done.