hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merged DEN-13834

    • -11
    • +59
    /firmware/App/Controllers/DGInterface.c
    • -43
    • +64
    /firmware/App/Controllers/DGInterface.h
    • -12
    • +112
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +10
    /firmware/App/Services/SystemComm.c
DEN-13903: DIAL-204: Init commit

    • -1
    • +28
    /firmware/App/Controllers/DialInFlow.c
Update header.

Update header.

Update header?

Update header?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should 365 be #define? Why changed from #define to static const U32?

Should 365 be #define? Why changed from #define to static const U32?

Should 250 be #define?

Should 250 be #define?

Should struct members be aligned?

Should struct members be aligned?

Last value is 0, should be 0.0. Do they need to be 0.0F?

Last value is 0, should be 0.0. Do they need to be 0.0F?

Magic number 1500. Give an explanation or define constant elsewhere.

Magic number 1500. Give an explanation or define constant elsewhere.

DEN-13834 updated the code

    • -12
    • +60
    /firmware/App/Controllers/DGInterface.c
    • -43
    • +64
    /firmware/App/Controllers/DGInterface.h
    • -12
    • +113
    /firmware/App/Modes/ModeStandby.c
    • -2
    • +10
    /firmware/App/Services/SystemComm.c
DEN-13598: Add persistence alarm using Windowscount for FPGA clock-spedd check

Is this indentation correct?

Is this indentation correct?

How is the event calibration update record being used?

How is the event calibration update record being used?

HD-DEN-13903_Sprint 80 MG Air Trap Optimization
HD-DEN-13903_Sprint 80 MG Air Trap Optimization
HD-DEN-13903_S80 MG Dial 204
HD-DEN-13903_S80 MG Dial 204
HD-DEN-13801_SW Dev Sprint 79 MG
HD-DEN-13801_SW Dev Sprint 79 MG
HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
What is this comment for?

What is this comment for?

Remove

Remove

Remove if not needed.

Remove if not needed.

DEN-13903: Changed Air Trap control to use the lower level sensor for opening and closing instead of the upper.

Merge branch 'DEN-13598-dg_hd_dev-sprint-77-fw-dong' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-13598-dg_hd_dev-sprint-77-fw-dong

DEN-13598: Add code for RAM error and FPGA clock speed.

Update header

Update header

Remove extra blank line.

Remove extra blank line.

I don't see this function implemented in c file.

I don't see this function implemented in c file.

Keep blank line.

Keep blank line.