hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +2
    /firmware/App/Controllers/DialOutFlow.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.c
    • -1
    • +1
    /firmware/App/Controllers/SyringePump.h
    • -1
    • +1
    /firmware/App/Controllers/Temperatures.c
    • -2
    • +2
    /firmware/App/Controllers/Temperatures.h
  1. … 27 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

I added the common branch to this code review.

I added the common branch to this code review.

DEN-13834 merged staging

    • -2
    • +15
    /firmware/App/Controllers/DGInterface.c
    • -12
    • +141
    /firmware/App/Modes/SelfTests.c
common and fwcommon repos are covered in the 13598 DG code review so not needed here.

common and fwcommon repos are covered in the 13598 DG code review so not needed here.

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this...

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this test only runs on a release build.

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Fixed merge conflicts

DEN-13598: Code review updates

DEN-13460 addressed the code review comments

    • -0
    • +1
    /firmware/App/Controllers/SyringePump.c
Done.

Done.

It is implemented.

It is implemented.

Done.

Done.

Done.

Done.

Done.

Done.

These variables will be deleted.

These variables will be deleted.

Done.

Done.