hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

HD-DIAL-278_Fan Pwm Override
HD-DIAL-278_Fan Pwm Override
Please check comment column alignment

Please check comment column alignment

Done.

Done.

Done.

Done.

HD-STT-2897_Bug Alarm 104 Alarm ID HD Air Trap Illegal Levels Triggers Before 2S
HD-STT-2897_Bug Alarm 104 Alarm ID HD Air Trap Illegal Levels Triggers Before 2S
Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface tha...

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

Remove blank line.

Remove blank line.

HD-DEN-16278_HD Pretreatment Prime Start State Does Not Allow Pause
HD-DEN-16278_HD Pretreatment Prime Start State Does Not Allow Pause
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.