hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Changed to persistence functions. Has been pushed to develop and tested.

Changed to persistence functions. Has been pushed to develop and tested.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Updated.

Updated.

Remove blank line.

Remove blank line.

Good catch. Consider replacing manual error timer counter with common persistence function.

Good catch. Consider replacing manual error timer counter with common persistence function.

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

Provide parameter name in prototype.

Provide parameter name in prototype.

This is a parameter, not an input.

This is a parameter, not an input.

Be explicit (i.e. TRUE == useShortStabilizeTime).

Be explicit (i.e. TRUE == useShortStabilizeTime).

Why set to false here? Seems like if statement in next state will always be false now.

Why set to false here? Seems like if statement in next state will always be false now.

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Rename function to name of state (like others).

Rename function to name of state (like others).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

HD-DIAL-278_Fan Pwm Override
HD-DIAL-278_Fan Pwm Override
Please check comment column alignment

Please check comment column alignment

Done.

Done.

Done.

Done.