hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Feb 2024
10:09 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

9:31 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:29 am

Sean Nash

You already did this in prior state.

You already did this in prior state.

9:26 am

Sean Nash

Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.

Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.

9:23 am

Sean Nash

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:10 am

Sean Nash

Maybe just name this stabilization 2.

Maybe just name this stabilization 2.

9:08 am

Sean Nash

period should be plural in comment and enum names.

period should be plural in comment and enum names.

9:07 am

Sean Nash

9:07 am

Sean Nash

9:04 am

Sean Nash

Maybe don't need this if we remove the switch statement.

Maybe don't need this if we remove the switch statement.

9:03 am

Sean Nash

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.

9:02 am

Sean Nash

Just set the 2 local array variables here outside the loop so you don't need the switch statement inside the loop.

Just set the 2 local array variables here outside the loop so you don't need the switch statement inside the loop.

9:01 am

Sean Nash

Remove space after cast.

Remove space after cast.

9:01 am

Sean Nash

Remove space after cast.

Remove space after cast.

9:00 am

Sean Nash

Do we want to start the 10 second delay when pump is turned on or off?

Do we want to start the 10 second delay when pump is turned on or off?

9:00 am

Sean Nash

Should this be an AND (not OR)?

Should this be an AND (not OR)?

8:54 am

Sean Nash

Recommend declaring this as an array here (1 for each sensor) so you don't need the switch statement.

Recommend declaring this as an array here (1 for each sensor) so you don't need the switch statement.

8:45 am

Dara Navaei

Fixed the code.

Fixed the code.

8:38 am

Dara Navaei

8:38 am

Dara Navaei

Thursday 01 Feb 2024
4:00 pm

Dara Navaei

HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation
HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation
Wednesday 31 Jan 2024
6:00 pm

Dara Navaei

HD-DEN-15953_Dialysate Temp Alarm Triggered After Dialysate Recirculation Stopped
HD-DEN-15953_Dialysate Temp Alarm Triggered After Dialysate Recirculation Stopped
4:42 pm

dcox  (deleted user)

I removed the old style software config test and this fixes the indents / brackets.

I removed the old style software config test and this fixes the indents / brackets.

3:03 pm

Vinayakam Mani

Done.

Done.

12:42 pm

Sean Nash

12:42 pm

Sean Nash

12:23 pm

Sean Nash

Remove extra space after >. Add () around inner conditions.

Remove extra space after >. Add () around inner conditions.

12:23 pm

Sean Nash

Remove space before comma.

Remove space before comma.