hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

You already did this in prior state.

You already did this in prior state.

Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.

Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Maybe just name this stabilization 2.

Maybe just name this stabilization 2.

period should be plural in comment and enum names.

period should be plural in comment and enum names.

Maybe don't need this if we remove the switch statement.

Maybe don't need this if we remove the switch statement.

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.

Just set the 2 local array variables here outside the loop so you don't need the switch statement inside the loop.

Just set the 2 local array variables here outside the loop so you don't need the switch statement inside the loop.

Remove space after cast.

Remove space after cast.

Remove space after cast.

Remove space after cast.

Do we want to start the 10 second delay when pump is turned on or off?

Do we want to start the 10 second delay when pump is turned on or off?

Should this be an AND (not OR)?

Should this be an AND (not OR)?

Recommend declaring this as an array here (1 for each sensor) so you don't need the switch statement.

Recommend declaring this as an array here (1 for each sensor) so you don't need the switch statement.

Fixed the code.

Fixed the code.

HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation
HD-DENBUG-163_High Venous Pressure Alarm 130 Triggers During Normal Treatment Operation
HD-DEN-15953_Dialysate Temp Alarm Triggered After Dialysate Recirculation Stopped
HD-DEN-15953_Dialysate Temp Alarm Triggered After Dialysate Recirculation Stopped
I removed the old style software config test and this fixes the indents / brackets.

I removed the old style software config test and this fixes the indents / brackets.

Done.

Done.

Remove extra space after >. Add () around inner conditions.

Remove extra space after >. Add () around inner conditions.

Remove space before comma.

Remove space before comma.