hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DENBUG-335 implemented the changes from staging

    • -11
    • +48
    /firmware/App/Controllers/AirTrap.c
    • -48
    • +51
    /firmware/App/Controllers/AirTrap.h
    • -8
    • +34
    /firmware/App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.h
    • -34
    • +66
    /firmware/App/Modes/TreatmentStop.c
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merged DENBUG-335

HD-DENBUG-335_Air Trap Fill Design Improvement P1B Staging
HD-DENBUG-335_Air Trap Fill Design Improvement P1B Staging
HD-DENBUG-335_Air Trap Fill Design Improvem
HD-DENBUG-335_Air Trap Fill Design Improvem
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'DENBUG-335-air-trap-fill-design-improvem' into develop

DENBUG-335 changed the persistent time of alarm 215 from 60 seconds to 30 seconds

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatmentParams.h
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merged DENBUG-335

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Done

Done

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

The comment was left here to make sure the next developer does not ask the question that the blood pump was not set here. It is a note to remind the developer that the ramp is set below.

The comment was left here to make sure the next developer does not ask the question that the blood pump was not set here. It is a note to remind the developer that the ramp is set below.

Can we move the comment where required?

Can we move the comment where required?

DENBUG-335 addressed the code review comments

Dara, work with Nick to get the right text for this new alarm.

Dara, work with Nick to get the right text for this new alarm.

We changed the order of ORs. But the parenthesis match otherwise, it would not compile.

We changed the order of ORs. But the parenthesis match otherwise, it would not compile.

Done

Done

Done

Done

No this comment is explaining what will happen at the bottom.

No this comment is explaining what will happen at the bottom.

Need to remove comment? or missing implementation?

Need to remove comment? or missing implementation?