hdfirmware / firmware / App / Controllers

PresOccl.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 11
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 05 Feb 2024
3:23 pm

Vinayakam Mani

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, fl...

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

3:22 pm

Vinayakam Mani

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, fl...

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

1:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Sean Nash

I think this function should set the old reset flag to FALSE here. Function doesn't need a parameter because it is only called when valve closes which should always set reset flag to FALSE.

I think this function should set the old reset flag to FALSE here. Function doesn't need a parameter because it is only called when valve closes which should always set reset flag to FALSE.

1:24 pm

Sean Nash

I think reset flag should not be set here. Should be set by new function when valve is closed I think.

I think reset flag should not be set here. Should be set by new function when valve is closed I think.

1:23 pm

Sean Nash

Should also set new flag to FALSE here I think.

Should also set new flag to FALSE here I think.

1:20 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:20 pm

Sean Nash

Shouldn't this be set to TRUE?

Shouldn't this be set to TRUE?

1:19 pm

Sean Nash

Add space between if and (. Add to comment that low venous pressure must be exempt to increment counter.

Add space between if and (. Add to comment that low venous pressure must be exempt to increment counter.

12:12 pm

Vinayakam Mani

Done.

Done.

12:12 pm

Vinayakam Mani

Done.

Done.

12:12 pm

Vinayakam Mani

Done.

Done.

12:11 pm

Vinayakam Mani

Done.

Done.

12:11 pm

Vinayakam Mani

Done.

Done.

Friday 02 Feb 2024
4:52 pm

Vinayakam Mani

Done

Done

10:09 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

This effectively changes exemption start to time of valve open instead of close. We don't want to do that.

9:29 am

Sean Nash

You already did this in prior state.

You already did this in prior state.

9:26 am

Sean Nash

Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.

Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.

9:23 am

Sean Nash

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:10 am

Sean Nash

Maybe just name this stabilization 2.

Maybe just name this stabilization 2.

9:08 am

Sean Nash

period should be plural in comment and enum names.

period should be plural in comment and enum names.

9:04 am

Sean Nash

Maybe don't need this if we remove the switch statement.

Maybe don't need this if we remove the switch statement.

9:03 am

Sean Nash

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.