Activity hdfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 28 Feb 2022

4:19 pm

Hung Nguyen <hnguyen@diality.com>

More
2693297
changed 2 files
DEN-11250-hd-syringe-pump-updates HD-DEN-11250-1

DEN-11250 Fixed syringe pump occlusion alarm not triggered

- -4
- +1
./SyringePump.c
- History
- Source
- Diff
./SyringePump.c
… 1 more file in changeset.

4:08 pm

Hung Nguyen <hnguyen@diality.com>

More
eb60ac3
changed 2 files
demo_branch, develop and 2 more

DEN-11250 Fixed syringe pump occlusion alarm not triggered

- -4
- +1
./SyringePump.c
- History
- Source
- Diff
./SyringePump.c
… 1 more file in changeset.

10:49 am

Dara Navaei

More
bcd401a
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 updated the temperature sensor (PBA_ADC)

- -3
- +2
./Temperatures.c
- History
- Source
- Diff
./Temperatures.c

Saturday 26 Feb 2022

1:56 pm

Dara Navaei

More
84cc99f
changed 5 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750, DEN-12232 addressed the code review comments and updated the fasn monitor

- -13
- +26
./Fans.c
- History
- Source
- Diff
./Fans.c
- -0
- +2
./Fans.h
- History
- Source
- Diff
./Fans.h
- -5
- +5
./FluidLeak.c
- History
- Source
- Diff
./FluidLeak.c
… 2 more files in changeset.

12:30 pm

Dara Navaei

Sean Nash please reply.

Sean Nash please reply.

12:30 pm

Dara Navaei

Good point, I updated it.

Good point, I updated it.

12:28 pm

Dara Navaei

I uninitialized it.

I uninitialized it.

12:28 pm

Dara Navaei

That is right.

That is right.

12:27 pm

Dara Navaei

Sean Nash please reply.

Sean Nash please reply.

12:27 pm

Dara Navaei

Sean Nash please respond,.

Sean Nash please respond,.

12:26 pm

Dara Navaei

This code has been removed already.

This code has been removed already.

12:23 pm

Dara Navaei

Yes. We might go back to it.

Yes. We might go back to it.

12:23 pm

Dara Navaei

It must be removed.

It must be removed.

Friday 25 Feb 2022

5:23 pm

Dara Navaei

More
23016be
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 updated the fill modes

- -2
- +2
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c
… 2 more files in changeset.

Thursday 24 Feb 2022

2:29 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Shouldn't this include be in TaskGeneral.c?

Shouldn't this include be in TaskGeneral.c?

2:24 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Is the commented test code still needed?

Is the commented test code still needed?

2:21 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Venous pressure does not have an error count. Is it needed?

Venous pressure does not have an error count. Is it needed?

2:18 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Do we want to keep this commented out defs?

Do we want to keep this commented out defs?

2:16 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Should 300 be a magic number?

Should 300 be a magic number?

2:04 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Should 300 be a magic number?

Should 300 be a magic number?

2:03 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

There are no changes in this file and its not a new file.

There are no changes in this file and its not a new file.

1:48 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Did we ever get clarification on these threshold values?

Did we ever get clarification on these threshold values?

1:46 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Is this supposed to be assigned to zero? it is unlike the other variables that have been changed

Is this supposed to be assigned to zero? it is unlike the other variables that have been changed

1:42 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

based on the struct, fanStatus.dutycycle does not need to be initialized NUM_OF_FANS_NAMES times.

based on the struct, fanStatus.dutycycle does not need to be initialized NUM_OF_FANS_NAMES times.

1:34 pm

Michael Garthwaite

More
Re: HD-DEN-11750-2
commented on review

Do these variables need to be volatile?

Do these variables need to be volatile?

Wednesday 23 Feb 2022

7:36 am

Dara Navaei

More
HD-DEN-11750-2
started review

HD-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

HD-DEN-11750_DG Dev Dialysate Temperature Control Tune Up

Tuesday 22 Feb 2022

5:55 pm

Dara Navaei

More
43a8413
changed 16 files
demo_branch, develop and 2 more

Merged DEN-11750

- -4
- +4
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -15
- +16
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
- -1
- +1
./BloodLeak.h
- History
- Source
- Diff
./BloodLeak.h
- -1
- +1
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -1
- +1
./DGInterface.h
- History
- Source
- Diff
./DGInterface.h
- -4
- +4
./DialInFlow.c
- History
- Source
- Diff
./DialInFlow.c
- -6
- +5
./DialOutFlow.c
- History
- Source
- Diff
./DialOutFlow.c
- -3
- +4
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c
- -18
- +19
./SyringePump.c
- History
- Source
- Diff
./SyringePump.c
… 7 more files in changeset.

5:35 pm

Dara Navaei

More
d4c8e02
changed 6 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-DEN-11750-2

DEN-11750 updated the fans override function to seconds and added the Code Clinic comments

- -1
- +1
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -1
- +1
./DialInFlow.c
- History
- Source
- Diff
./DialInFlow.c
- -2
- +1
./DialOutFlow.c
- History
- Source
- Diff
./DialOutFlow.c
- -4
- +3
./Fans.c
- History
- Source
- Diff
./Fans.c
- -1
- +1
./Fans.h
- History
- Source
- Diff
./Fans.h
… 1 more file in changeset.

2:50 pm

Sean Nash

More
da838b2
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

- -11
- +21
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -10
- +22
./DialInFlow.c
- History
- Source
- Diff
./DialInFlow.c
- -10
- +20
./DialOutFlow.c
- History
- Source
- Diff
./DialOutFlow.c

2:50 pm

Sean Nash

More
98d8996
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 336 more HD-UCOMMITS-19

Added F suffix to pump pwm offset literals to fix failure to detect pump running while off alarm.

- -1
- +1
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -1
- +1
./DialInFlow.c
- History
- Source
- Diff
./DialInFlow.c
- -1
- +1
./DialOutFlow.c
- History
- Source
- Diff
./DialOutFlow.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-06 13:18 -0700