Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-11250 Fixed syringe pump occlusion alarm not triggered - moved commit 269329748ff from DEN-11250 to here

Removed // if ( TRUE == getNoNewTreatmentStatus() ) //{ // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }

Removed
// if ( TRUE == getNoNewTreatmentStatus() )
//

Unknown macro: { // rejReason = REQUEST_REJECT_REASON_NO_NEW_TREATMENT_ALARM_TRIGGERED; // }
Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

Removed line //noNewTreatment = ( TRUE == ALARM_TABLE[ a ].alarmNoNewTreatment ? TRUE : noNewTreatment );

Just delete this line of code.

Just delete this line of code.

Just delete this line of code.

Just delete this line of code.

Just delete this code.

Just delete this code.

It looks like staging branch has things the way it was too.

It looks like staging branch has things the way it was too.

Should be since last service (not last treatment).

Should be since last service (not last treatment).

This was part of the merge from staging branch.

This was part of the merge from staging branch.

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

What is the reason for these changes? Just reading the code, it makes more sense to me that way it was.

DEN_12224 merged CodeClinic's changes and resolved the merge conflicts

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

DEN-12224 updated the fans driver

DEN-12224: Updated initial DP PWM estimate equations based on preliminary data.

0xA04E was originally MSG_ID_DG_HD_COMMUNICATION_STATUS_OVERRIDE. It was moved to 0xA008 due to an out of sync error in our lovely excel sheet. MSG_ID_DG_SET_FANS_RPM_ALARM_START_TIME_OFFSET should...

0xA04E was originally MSG_ID_DG_HD_COMMUNICATION_STATUS_OVERRIDE. It was moved to 0xA008 due to an out of sync error in our lovely excel sheet. MSG_ID_DG_SET_FANS_RPM_ALARM_START_TIME_OFFSET should now be 0xA04E.

Note: These values are what is currently reflected on staging.

Where is 0xA04E?

Where is 0xA04E?

DEN-12224, DEN-12232 updated the fans driver

Merged DEN-12224

  1. … 1 more file in changeset.
DEN-12215 Merged Staging branch. Updated DG_FILL_ defs, WET_SELF_TESTS_ defs.

  1. … 37 more files in changeset.
Added exception for Stopped sub states and before door should be closed.

Added exception for Stopped sub states and before door should be closed.

Added

Added

Added.

Added.

Added.

Added.

Good catch. Updated.

Good catch. Updated.

Moved and used getSwitchStatus to ensure overrides work.

Moved and used getSwitchStatus to ensure overrides work.

DEN-12224 updated the software configurations

  1. … 1 more file in changeset.
DEN-10974 Code review updates

  1. … 3 more files in changeset.
Sean said leave it as is. No harm to be done.

Sean said leave it as is. No harm to be done.

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.