hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 7
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Aug 2022
10:24 am

Sean Nash

DEN-13460: Adjusted DPi initial PWM estimate per data from Eliza.

Options
    • -2
    • +1
    ./DialInFlow.c
  2. … 1 more file in changeset.
9:07 am

Dong Nguyen

I removed all counters.

I removed all counters.

9:05 am

Dong Nguyen

I added a blank line above those new constants.

I added a blank line above those new constants.

Monday 29 Aug 2022
12:47 pm

Dara Navaei

Disabled the interface alarms

Options
    • -2
    • +2
    ./DGInterface.c
11:28 am

Sean Nash

Do we need counters since we're using persistent alarms?

Do we need counters since we're using persistent alarms?

11:27 am

Sean Nash

Add blank line above these new constants.

Add blank line above these new constants.

9:43 am

Dara Navaei

DEN-13460 updated the blood leak sensor driver

Options
    • -2
    • +2
    ./BloodLeak.c
  2. … 2 more files in changeset.
Friday 26 Aug 2022
3:38 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598 Add code for new alarms.

Options
    • -11
    • +166
    ./DGInterface.c
    • -0
    • +1
    ./DGInterface.h
    • -2
    • +3
    ./Temperatures.c
  4. … 4 more files in changeset.
3:16 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598 Add code for new alarms.

Options
    • -20
    • +0
    ./DGInterface.c
3:04 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./PresOccl.c
  2. … 3 more files in changeset.
3:02 pm

Michael Garthwaite

2:59 pm

Dara Navaei and Sean Nash

2:47 pm

Dong Nguyen <dnguyen@diality.com>

DEN-13598 Add code fornew alarms.

Options
    • -128
    • +82
    ./DGInterface.c
    • -1
    • +1
    ./DGInterface.h
    • -2
    • +1
    ./Temperatures.c
  4. … 4 more files in changeset.
2:14 pm

dcox  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

dcox  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:13 pm

dcox  (deleted user)

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:06 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:58 am

dcox  (deleted user)

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.

11:56 am

dcox  (deleted user)

Uncomment or add a comment explaining why it is inactive.

Uncomment or add a comment explaining why it is inactive.

11:55 am

dcox  (deleted user)

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.

10:19 am

Michael Garthwaite

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarm...

We can get to this but bloodPumpOcclusionAfterCartridgeInstall will be set to 0. Therefore, bpOccl will need to be <= 5500 for the alarm to clear. Im unsure if it would be a problem. We use isAlarmTriggered() to clear it only if has been raised previously.

Open to discussion in code walkthrough.

10:14 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

Understood. Fixed. Thanks!

Understood. Fixed. Thanks!

10:13 am

Michael Garthwaite

code review changes

Options
    • -13
    • +5
    ./PresOccl.c