Activity hdfirmware/firmware/App/Controllers

10:46 am

Dara Navaei

More
4fc093e
changed 7 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 311 more HD-DEN-13834-1

DEN-13834 added the DG heaters broadcast message. Addded a function to check the status of the trimmer heater's state in DGInterface and keep sending the command from HD until the trimmer heater is in the right status. Enabled stop/start trimmer command in the modes

- -1
- +41
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -29
- +1
./DGInterface.h
- History
- Source
- Diff
./DGInterface.h
- -10
- +0
./DialOutFlow.h
- History
- Source
- Diff
./DialOutFlow.h
… 4 more files in changeset.

4:27 pm

Sean Nash

I think the style is to use set/get functions if needed by other modules, otherwise just access the variable directly.

4:20 pm

Sean Nash

Need to initialize here at declaration or in init function. I see neither now.

4:52 pm

Dara Navaei

More
fb1673d
changed 15 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 316 more HD-DEN-13460-2 HD-DEN-13598-2 HD-DEN-13834-1

DEN-13460 addressed the code review comments

- -29
- +31
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
- -11
- +11
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -2
- +2
./DialInFlow.c
- History
- Source
- Diff
./DialInFlow.c
- -2
- +2
./DialOutFlow.c
- History
- Source
- Diff
./DialOutFlow.c
- -3
- +5
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c
- -3
- +2
./SyringePump.c
- History
- Source
- Diff
./SyringePump.c
- -7
- +6
./Temperatures.c
- History
- Source
- Diff
./Temperatures.c
- -5
- +5
./Valves.c
- History
- Source
- Diff
./Valves.c
… 7 more files in changeset.

4:37 pm

Dara Navaei

Thanks for the reminder.

4:36 pm

Dara Navaei

Done.

4:35 pm

Dara Navaei

More
Re: HD-DEN-13460-2
replied to wbracken (deleted user)

Done.

4:34 pm

Dara Navaei

More
Re: HD-DEN-13460-2
replied to wbracken (deleted user)

Done.

4:33 pm

Dara Navaei

More
Re: HD-DEN-13460-2
replied to wbracken (deleted user)

Done.

4:31 pm

Dara Navaei

More
Re: HD-DEN-13460-2
replied to wbracken (deleted user)

Done.

4:29 pm

Dara Navaei

More
Re: HD-DEN-13460-2
replied to wbracken (deleted user)

Done.

4:29 pm

Dara Navaei

More
Re: HD-DEN-13460-2
replied to wbracken (deleted user)

Done.

2:39 pm

Michael Garthwaite

More
Re: HD-DEN-13460-2
commented on review

More of a caution than an explicit fix. Dong's S77 branch has some of the changes that are reflected here. He also has the more recent commit. Be careful when both of you merge your branches.

2:33 pm