Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
common and fwcommon repos are covered in the 13598 DG code review so not needed here.

common and fwcommon repos are covered in the 13598 DG code review so not needed here.

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this...

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this test only runs on a release build.

Done.

Done.

It is implemented.

It is implemented.

Done.

Done.

Done.

Done.

Done.

Done.

These variables will be deleted.

These variables will be deleted.

Done.

Done.

The buffer has been increased in the DEN-13903.

The buffer has been increased in the DEN-13903.

Done.

Done.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

Update header.

Update header.

Update header?

Update header?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should 365 be #define? Why changed from #define to static const U32?

Should 365 be #define? Why changed from #define to static const U32?

Should 250 be #define?

Should 250 be #define?

Should struct members be aligned?

Should struct members be aligned?

Last value is 0, should be 0.0. Do they need to be 0.0F?

Last value is 0, should be 0.0. Do they need to be 0.0F?

Magic number 1500. Give an explanation or define constant elsewhere.

Magic number 1500. Give an explanation or define constant elsewhere.

Is this indentation correct?

Is this indentation correct?

How is the event calibration update record being used?

How is the event calibration update record being used?

HD-DEN-13903_Sprint 80 MG Air Trap Optimization
HD-DEN-13903_Sprint 80 MG Air Trap Optimization
HD-DEN-13903_S80 MG Dial 204
HD-DEN-13903_S80 MG Dial 204
HD-DEN-13801_SW Dev Sprint 79 MG
HD-DEN-13801_SW Dev Sprint 79 MG
HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
What is this comment for?

What is this comment for?

Remove

Remove

Remove if not needed.

Remove if not needed.

Update header

Update header