Activity hdfirmware/firmware/App/Controllers

4:38 pm

Sean Nash

More
Re: HD-DEN-14252-1
replied to jtaylor (deleted user)

Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

4:24 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

Where did this enum name change take place? There is no common in this code review.

4:22 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

remove "," after pwm.

4:22 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

Remove blank line.

4:21 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

4:19 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

Remove blank line.

4:19 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

First part of condition should have () around it too. Do we want to set direction here even if we fail to satisfy condition below?

First part of condition should have () around it too.
Do we want to set direction here even if we fail to satisfy condition below?

4:15 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

Keep a blank line between declaration and code.

4:14 pm

Sean Nash

More
Re: HD-DEN-14344-5
commented on review

Not clear on what this refactoring of condition changed - looks the same.

11:49 am

wbracken (deleted user)

More
Re: HD-DEN-14344-5
commented on review

parameter0?

10:55 am

Dara Navaei

More
Re: HD-DEN-14344-3
commented on review

Please add comment.

10:52 am

Dara Navaei

More
HD-DEN-14344-5
started review

HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix

9:37 am

jtaylor (deleted user)

More
Re: HD-DEN-14252-1
commented on review

It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

10:31 am

jtaylor (deleted user)

More
HD-DEN-14307-1
resumed reviewing

4:17 pm

wbracken (deleted user)

More
Re: HD-DEN-14344-3
commented on review

Alignment throughout the file. However, this file is auto-generated by HalCoGen.

4:05 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH.

2:02 pm

Michael Garthwaite

More
Re: HD-DEN-14344-3
replied to wbracken (deleted user)

HalCoGen is currently editing het.h, het.c, sys_link.cmd, HD.dil, and sys_selftest.c in this branch. Any and all the changes within those files are autogenerated from HaloCoGen.

1:53 pm