Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14344: code review comments.

  1. … 2 more files in changeset.
Created a #define for magic number. Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of de...

Created a #define for magic number.
Because running pumps in open loop mode (because we're priming and not necessarily any fluid in line to measure flow with) and pumps have different methods of determining PWM duty cycle from a given flow rate, DPo pumps target flow rate needed to be set lower to match the duty cycle with DPi pump.

Where did this enum name change take place? There is no common in this code review.

Where did this enum name change take place? There is no common in this code review.

remove "," after pwm.

remove "," after pwm.

Remove blank line.

Remove blank line.

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

Should this be set to true even if result below is false? Maybe set to true in testSetDialInPumpWithPWM() function after all of the conditions are found to be met?

Remove blank line.

Remove blank line.

First part of condition should have () around it too. Do we want to set direction here even if we fail to satisfy condition below?

First part of condition should have () around it too.
Do we want to set direction here even if we fail to satisfy condition below?

Keep a blank line between declaration and code.

Keep a blank line between declaration and code.

Not clear on what this refactoring of condition changed - looks the same.

Not clear on what this refactoring of condition changed - looks the same.

Auto stash before merge of "develop" and "origin/develop"

parameter0?

parameter0?

Please add comment.

Please add comment.

HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
HD-DEN-14344_SW S85 MG Dpi Pwmflow Fix
It seems strange to add a magic number here, from a defined constant. I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it...

It seems strange to add a magic number here, from a defined constant.
I'd assume (guess) the relation between 300->225 is maintaining a delta P along the flow path (or across the membrane?), but it might be worth spelling out, at the top with the defines, or as a macro function of the input flow rate.

Merge branch 'DEN-14252-system-self-test-failure-occurs-intermittently' into develop

DEN-14252 updated the getDGCommandResponse to not set the command ID to none until the command is done

Merged DEN-14252

  1. … 4 more files in changeset.
DEN-14344: DPI set pwm direction fix.

  1. … 1 more file in changeset.
DEN-14252: Candidate fix for DEN-14254 for syringe DAC issue.

  1. … 1 more file in changeset.
DEN-14344: DPi set pwm changes to handle direction

DEN-14344: fixed sw config checks. Updated dry self test thresholds to handle air pump performance.

  1. … 1 more file in changeset.
DEN-14344: WIP set dpi pwm

DEN-14344: fixed pwm to not compare vs NEARLY_ZERO. Fixed pwm to be a positive value when setting the PIN.

DEN-14344: merge conflicts and fixes.

  1. … 1 more file in changeset.
DEN-14344: DPi set pwm changes to handle new estimation functions.

DEN-14344: Air pump integration into air trap and dry self tests.

  1. … 1 more file in changeset.
DEN-14344: Air Pump integration into air trap control

DEN-14307 added PiSquare's VectorCAST

  1. … 2 more files in changeset.