Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15359: Addressed code review comments.

  1. … 1 more file in changeset.
Fixed.

Fixed.

Yes. Fixed.

Yes. Fixed.

Yes. Fixed.

Yes. Fixed.

Fixed.

Fixed.

Fixed.

Fixed.

same here?

same here?

Isn't the Venous Asymmetric missing?

Isn't the Venous Asymmetric missing?

don't you need to add the venous asymmetric here to be reset? Since I am going to give user an option to adjust it during treatment.

don't you need to add the venous asymmetric here to be reset?
Since I am going to give user an option to adjust it during treatment.

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-15359: finished arterial/venous pressure limits window update.

  1. … 3 more files in changeset.
Will always be integers. Prefer to store them that way.

Will always be integers. Prefer to store them that way.

DEN-15359: Additional implementation of arterial/venous pressure limit windows.

  1. … 3 more files in changeset.
If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare ...

If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare now; it's unclear whether they stop with AC returning or the operational state. Would we expect other operational impacts of operating from battery, or the loss and return of AC? Battery alarms, etc.?

The block timer runs from the time the condition clears in alarm management (cpld flag, or flag plus alarm state). If alarms are not included here, the timer may (probably will) time out with the alarm still active and the valves still improperly positioned. The valve position error will occur immediately after clearing the alarms, even with the alarms status checked in valves. The timer could be relocated to valves, but that doesn't take care of other sources of alarms after power recovery.

this might be clearer written as: data = MAX( 0.0F, data )

this might be clearer written as: data = MAX( 0.0F, data )

DEN-15359: Added treatment parameter for asymmetric on venous pressure alarm limits.

  1. … 5 more files in changeset.
Could these recently added variables be defined as F32 instead of casting?

Could these recently added variables be defined as F32 instead of casting?

DEN-15359: Addressed DEN-15381.

  1. … 1 more file in changeset.
DEN-15359: Addressed DEN-15284.

HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
DEN-15359: Updated tx params to change art/ven pressure limit params from min/max to window.

  1. … 4 more files in changeset.
The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

DEN-13865: Addressed code review comment.

DEN-15396 Use greater of 10sec or 10 Rotor turn times for minimum persistent error time.