hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 May 2023
10:38 pm

Sean Nash

Fixed.

Fixed.

10:38 pm

Sean Nash

Yes. Fixed.

Yes. Fixed.

10:36 pm

Sean Nash

Yes. Fixed.

Yes. Fixed.

10:34 pm

Sean Nash

Fixed.

Fixed.

10:34 pm

Sean Nash

Fixed.

Fixed.

8:05 pm

Behrouz NematiPour

same here?

same here?

8:05 pm

Behrouz NematiPour

Isn't the Venous Asymmetric missing?

Isn't the Venous Asymmetric missing?

5:41 pm

Behrouz NematiPour

don't you need to add the venous asymmetric here to be reset? Since I am going to give user an option to adjust it during treatment.

don't you need to add the venous asymmetric here to be reset?
Since I am going to give user an option to adjust it during treatment.

1:52 pm

Behrouz NematiPour

12:17 am

wbracken  (deleted user)

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

12:16 am

wbracken  (deleted user)

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Saturday 27 May 2023
11:53 pm

wbracken  (deleted user)

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

11:51 pm

wbracken  (deleted user)

Add pressureLimitsActive to header.

Add pressureLimitsActive to header.

11:49 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Friday 26 May 2023
3:20 pm

jtaylor  (deleted user)

1:46 pm

Sean Nash

Will always be integers. Prefer to store them that way.

Will always be integers. Prefer to store them that way.

9:39 am

jtaylor  (deleted user)

If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare ...

If we think that this is the only spurious alarm that may occur with power loss. We know fan rpm also occurs, but the fans do recover when AC returns. Comm errors have occurred, but they seem rare now; it's unclear whether they stop with AC returning or the operational state. Would we expect other operational impacts of operating from battery, or the loss and return of AC? Battery alarms, etc.?

The block timer runs from the time the condition clears in alarm management (cpld flag, or flag plus alarm state). If alarms are not included here, the timer may (probably will) time out with the alarm still active and the valves still improperly positioned. The valve position error will occur immediately after clearing the alarms, even with the alarms status checked in valves. The timer could be relocated to valves, but that doesn't take care of other sources of alarms after power recovery.

9:09 am

jtaylor  (deleted user)

this might be clearer written as: data = MAX( 0.0F, data )

this might be clearer written as: data = MAX( 0.0F, data )

Thursday 25 May 2023
11:44 am

wbracken  (deleted user)

Could these recently added variables be defined as F32 instead of casting?

Could these recently added variables be defined as F32 instead of casting?

Wednesday 24 May 2023
1:29 pm

Dara Navaei

HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
HD-DEN-15359_Usability Arterial And Venous Pressure Alarm Limits
9:20 am

jtaylor  (deleted user)

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

Tuesday 23 May 2023
8:36 am

Sean Nash

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

8:35 am

Sean Nash

Do we need the alarm active checks? Isn't power loss check sufficient?

Do we need the alarm active checks? Isn't power loss check sufficient?

12:02 am

Dara Navaei

HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
Monday 22 May 2023
1:40 pm

Michael Garthwaite

11:59 am

jtaylor  (deleted user)

The root cause is that abnormal AC power loss on the HD causes abnormal operating conditions and spurious errors. The valves return to position after the alarm is cleared, not when AC returns. The ...

The root cause is that abnormal AC power loss on the HD causes abnormal operating conditions and spurious errors. The valves return to position after the alarm is cleared, not when AC returns. The timer gives a ten-second window following removing the power fail signal and the alarm condition, where the alarm block is active. The original block used the alarms alone, we changed to the CPLD power loss detection - which returns with the return of AC. Clearing the alarms late means removing the block before the valves return to normal operation.

I think there are two approaches. We already have distributed failsafe that is entered on power fail, which we recover from after the alarm is cleared.
1. Create a pervasive state that affects every operating mode, allowing transitions to "safe" states during alarms, then back to the original operating state. The safe state would not register errors until after the transition back to normal operation.
2. Block errors until both AC is returned and the alarm is cleared when normal operation is restored.

The second approach is much simpler and addresses the root problem: odd control configurations resulting from having alarms with conflicting controls. In this case, the secondary alarms are spurious since they result from the valves dropping into a safe position, for instance, on the loss of AC. We also have a handful of other errors that occur under these conditions, fan speed, for instance, as well as valve positions,

11:57 am

jtaylor  (deleted user)

Added alarm 62 detection disable as suggested.

Added alarm 62 detection disable as suggested.

10:02 am

Dara Navaei

HD-DEN-15396_2 Alarm 42 HD Fault Dpo Rotor Encountered IN Blood Prime Dvt 00
HD-DEN-15396_2 Alarm 42 HD Fault Dpo Rotor Encountered IN Blood Prime Dvt 00
Sunday 21 May 2023
2:44 pm

Dara Navaei

2:14 pm

Dara Navaei and Sean Nash