Activity hdfirmware/firmware/App/Controllers

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	16
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 14 Jun 2023

3:34 pm

Sean Nash

More
6d19d84
changed 3 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 195 more HD-DEN-15489-1

DEN-15489: Addressed issue with preventing pumps to be commanded to top speed.

- -2
- +5
./BloodFlow.c
- History
- Source
- Diff
./BloodFlow.c
- -1
- +3
./DialInFlow.c
- History
- Source
- Diff
./DialInFlow.c
- -1
- +1
./DialOutFlow.c
- History
- Source
- Diff
./DialOutFlow.c

2:28 pm

Dara Navaei

More
HD-DEN-15489-1
started review

HD-DEN-15489_FW DG Disinfect Has Expired Check Does Not Clear With Valid Dates

HD-DEN-15489_FW DG Disinfect Has Expired Check Does Not Clear With Valid Dates

12:59 pm

Dara Navaei

More
HD-DEN-15306-3
Closed

12:57 pm

Sean Nash

More
HD-DEN-15306-3
finished reviewing

10:43 am

Michael Garthwaite

More
8126d8e
changed 7 files
develop

Merge branch 'DEN-15196-DIAL-262-fixes' into develop

- -2
- +2
./BloodLeak.h
- History
- Source
- Diff
./BloodLeak.h
- -2
- +4
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -2
- +2
./DGInterface.h
- History
- Source
- Diff
./DGInterface.h
… 4 more files in changeset.

10:27 am

Sean Nash

More
HD-DEN-15363-1
finished reviewing

10:26 am

Dara Navaei

More
f1157c7
changed 15 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 197 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
- -1
- +1
./BloodLeak.h
- History
- Source
- Diff
./BloodLeak.h
- -2
- +2
./DGInterface.c
- History
- Source
- Diff
./DGInterface.c
- -2
- +2
./DGInterface.h
- History
- Source
- Diff
./DGInterface.h
… 11 more files in changeset.

10:22 am

Dara Navaei

More
HD-DEN-15367-1
Closed

10:18 am

dcox (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:11 am

Dara Navaei

More
Re: HD-DEN-15367-1
replied to dcox (deleted user)

It is called in the translationToStandyMode in the function clearCurrentCleaningModeStatus().

It is called in the translationToStandyMode in the function clearCurrentCleaningModeStatus().

10:11 am

Sean Nash

More
HD-DEN-15367-1
finished reviewing

10:08 am

dcox (deleted user)

More
Re: HD-DEN-15367-1
commented on review

Where is currentDGCleaningMode initialized?

Where is currentDGCleaningMode initialized?

9:56 am

Dara Navaei

More
e63dcc4
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more HD-DEN-15367-1

DEN-15367 merged staging

- -8
- +15
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
… 1 more file in changeset.

9:30 am

Sean Nash

More
1949c8b
changed 2 files
develop

Fixed merge conflicts.

- -2
- +2
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
- -3
- +3
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

9:29 am

Sean Nash

More
HD-DEN-15558-1
Closed

9:25 am

Dara Navaei

More
e288ab9
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

9:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 am

Dara Navaei

More
Re: HD-DEN-15367-1
replied to Sean Nash

Done

Done

9:07 am

Sean Nash

More
Re: HD-DEN-15367-1
commented on review

Implicit bool to BOOL conversion. Prefer explicit conversion with ternary.

Implicit bool to BOOL conversion. Prefer explicit conversion with ternary.

9:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:05 am

jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:02 am

Michael Garthwaite

More
HD-DEN-15558-1
finished reviewing

Tuesday 13 Jun 2023

5:20 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:19 pm

wbracken (deleted user)

More
Re: HD-DEN-15558-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

3:34 pm

Dara Navaei

More
f249310
changed 5 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 198 more HD-DEN-15367-1

DEN-15367 addressed the code review comments. Added code to check the payload of the message that is received from DG to indicate that DG is ready to dispense more water in RO permeate sample mode

- -2
- +3
./BloodLeak.c
- History
- Source
- Diff
./BloodLeak.c
… 4 more files in changeset.

3:33 pm

Sean Nash

More
Re: HD-DEN-15558-1
replied to wbracken (deleted user)

Done.

Done.

3:33 pm

Dara Navaei

More
Re: HD-DEN-15367-1
replied to Sean Nash

Done

Done

3:33 pm

Dara Navaei

More
Re: HD-DEN-15367-1
replied to wbracken (deleted user)

Done

Done

3:32 pm

Sean Nash

More
f0e53bc
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 199 more HD-DEN-15558-1

DEN-15558: Addressed code review comment.

- -2
- +2
./PresOccl.c
- History
- Source
- Diff
./PresOccl.c

3:32 pm

Dara Navaei

More
Re: HD-DEN-15367-1
replied to jtaylor (deleted user)

Aligned, thanks.

Aligned, thanks.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-26 12:37 -0700