hdfirmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Aug 2023
3:50 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

STT-2897 Replace alarm persistence counter with persistent alarm functions

Options
    • -18
    • +16
    ./AirTrap.c
2:41 pm

Sean Nash

2:41 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:29 pm

Sean Nash

2:29 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:32 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:31 pm

Michael Garthwaite

DEN-16203: code review comments

Options
    • -1
    • +0
    ./DialOutFlow.c
1:17 pm

Vinayakam Mani

Updated.

Updated.

1:09 pm

Sean Nash

Remove blank line.

Remove blank line.

1:08 pm

Sean Nash

Good catch. Consider replacing manual error timer counter with common persistence function.

Good catch. Consider replacing manual error timer counter with common persistence function.

1:02 pm

Sean Nash

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

1:01 pm

Sean Nash

Provide parameter name in prototype.

Provide parameter name in prototype.

1:00 pm

Sean Nash

This is a parameter, not an input.

This is a parameter, not an input.

12:57 pm

Sean Nash

Be explicit (i.e. TRUE == useShortStabilizeTime).

Be explicit (i.e. TRUE == useShortStabilizeTime).

12:57 pm

Sean Nash

Why set to false here? Seems like if statement in next state will always be false now.

Why set to false here? Seems like if statement in next state will always be false now.

12:54 pm

Sean Nash

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

Rename function to name of state (like others).

Rename function to name of state (like others).

11:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:15 am

Michael Garthwaite

DEN-16203: changed dopMeasuredRate to handle set flow rate in open loop state.

Options
    • -3
    • +11
    ./DialOutFlow.c
10:04 am

Dara Navaei

HD-DIAL-278_Fan Pwm Override
HD-DIAL-278_Fan Pwm Override
9:29 am

Vinayakam Mani

DEN-16093 merge in to develop

Options
    • -0
    • +15
    ./DGInterface.c
    • -0
    • +1
    ./DGInterface.h
  3. … 2 more files in changeset.
8:50 am

jtaylor  (deleted user)

Please check comment column alignment

Please check comment column alignment

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

Done.

Done.

6:04 pm

Vinayakam Mani

Done.

Done.

5:18 pm

Darren Cox <darren_m@cox.net>

DEN-15980 Air pump mods: longer ON time, shorter stabilize pressure time, add alarm framework for air pump on too much.

Options
    • -2
    • +13
    ./AirTrap.c
    • -11
    • +43
    ./PresOccl.c
    • -2
    • +2
    ./PresOccl.h
  4. … 3 more files in changeset.
2:34 pm

Dara Navaei

HD-STT-2897_Bug Alarm 104 Alarm ID HD Air Trap Illegal Levels Triggers Before 2S
HD-STT-2897_Bug Alarm 104 Alarm ID HD Air Trap Illegal Levels Triggers Before 2S
2:16 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

STT-2897 Correct alarm persistence

Options
    • -4
    • +5
    ./AirTrap.c
1:45 pm

Sean Nash

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface tha...

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

1:38 pm

Sean Nash

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".