Controllers

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed merge conflict.

  1. … 1 more file in changeset.
DEN-16851 merge into develop

DEN-16851 periodic occlusion baseline update

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

DEN-16851 merge into develop

  1. … 3 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done

Done

Done

Done

Done

Done

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.

Done.

Done.

Done.

Done.

DEN-16851 fixed code review comments

I think we just want to publish the baseline here (not +1000).

I think we just want to publish the baseline here (not +1000).

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32. You might want to cast the total as F32 as we...

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32.
You might want to cast the total as F32 as well for consistency.

F32 not needed here.

F32 not needed here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Casting not necessary.

Casting not necessary.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Are we guaranteed to be in Treatment mode here? If not, check mode too.

Are we guaranteed to be in Treatment mode here? If not, check mode too.