hdfirmware / firmware / App / Modes

ModeUpdate.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 Nov 2024
12:58 pm

Dara Navaei

12:53 pm

Dara Navaei

12:53 pm

Dara Navaei

Thursday 06 Jun 2024
10:53 am

Sean Nash

Why is bootloader executing in a different mode than app? Is that necessary? How will mode switch back to user when jumping to app?

Why is bootloader executing in a different mode than app? Is that necessary? How will mode switch back to user when jumping to app?

Friday 24 May 2024
11:55 am

Vinayakam Mani

Bootloader seems to be executed in supervisory mode. if so, the current allocated stack for supervisory mode is 1K (if we merge into existing HD/DG firmware). we may need to watch for supervisory m...

Bootloader seems to be executed in supervisory mode. if so, the current allocated stack for supervisory mode is 1K (if we merge into existing HD/DG firmware). we may need to watch for supervisory mode stack size, in case boot loader consumes more that 1K?

11:48 am

Vinayakam Mani

the second value is 0x00 or 0xFFFFFFFF? The bootloader checks the value is not equal to 0xFFFFFFFF, if so, the valid application is not found, and firmware needs to be updated.

the second value is 0x00 or 0xFFFFFFFF?

The bootloader checks the value is not equal to 0xFFFFFFFF, if so, the valid application is not found, and firmware needs to be updated.

11:27 am

Vinayakam Mani

Looks to be memory overflow to be occurred. src-> pointing the buffer of 4 bytes length. bytes-> mentioning 16 bytes length. g_pulUpdateSuccess[] should be allocated more than the current size. Als...

Looks to be memory overflow to be occurred. src-> pointing the buffer of 4 bytes length. bytes-> mentioning 16 bytes length. g_pulUpdateSuccess[] should be allocated more than the current size. Also, Do we need to typecast "(uint32_t) bytes", since the api mentioning (uint8_t)?

Fapi_StatusType Fapi_issueProgrammingCommand(
uint32_t *pu32StartAddress,
uint8_t *pu8DataBuffer,
uint8_t u8DataBufferSizeInBytes,
uint8_t *pu8EccBuffer,
uint8_t u8EccBufferSizeInBytes,
Fapi_FlashProgrammingCommandType oMode)

Thursday 25 Jan 2024
2:34 pm

Darren Cox

These are not in HD where all go to one function. Should this be common code between DG and HD?

These are not in HD where all go to one function. Should this be common code between DG and HD?

Friday 22 Dec 2023
9:31 am

Sean Nash

9:29 am

Sean Nash

Do we really want to use a whole flash sector for a flag? I thought bootloader was going to talk to UI to determine whether an update was in progress?

Do we really want to use a whole flash sector for a flag? I thought bootloader was going to talk to UI to determine whether an update was in progress?

9:09 am

Sean Nash

What is this for?

What is this for?

9:08 am

Sean Nash

This is adding conversion to binary step post-build, correct? Are we losing the alarm check here?

This is adding conversion to binary step post-build, correct? Are we losing the alarm check here?

9:06 am

Sean Nash

Don't make changes outside of user code sections.

Don't make changes outside of user code sections.

9:05 am

Sean Nash

So app start address is offset by 64K. Assuming that is plenty of room for bootloader but we should check. Also, have we checked that the first 64K of Flash memory is discreet sector-wise? We do no...

So app start address is offset by 64K. Assuming that is plenty of room for bootloader but we should check.
Also, have we checked that the first 64K of Flash memory is discreet sector-wise? We do not want bootloader and app sharing a sector.

9:01 am

Sean Nash

Why aren't each of these messages calling their own handler function? They appear to exist in SystemCommMessages.c so I believe that was the intent.

Why aren't each of these messages calling their own handler function? They appear to exist in SystemCommMessages.c so I believe that was the intent.

8:59 am

Sean Nash

Should we use new reboot function in Update.c?

Should we use new reboot function in Update.c?

8:58 am

Sean Nash

Spaces in (). Be explicit on BOOL conditions.

Spaces in (). Be explicit on BOOL conditions.

8:58 am

Sean Nash

Spaces in ().

Spaces in ().

8:57 am

Sean Nash

Why not call the reboot function in Update.c?

Why not call the reboot function in Update.c?

8:57 am

Sean Nash

Spaces inside (). Be explicit with BOOL conditions.

Spaces inside (). Be explicit with BOOL conditions.

8:57 am

Sean Nash

Spaces inside (). Use ternary to set to TRUE or FALSE explicitly.

Spaces inside (). Use ternary to set to TRUE or FALSE explicitly.

8:56 am

Sean Nash

Where is this being called?

Where is this being called?

8:55 am

Sean Nash

This message will not get sent immediately - it is only queued. Reset will occur before transmit.

This message will not get sent immediately - it is only queued. Reset will occur before transmit.

8:54 am

Sean Nash

Where is this called?

Where is this called?

8:53 am

Sean Nash

I don't see SystemComm calling this or reboot function. Why are they here?

I don't see SystemComm calling this or reboot function. Why are they here?

8:51 am

Sean Nash

These changes look wrong. This is UI comm check.

These changes look wrong. This is UI comm check.

8:49 am

Sean Nash

Need doxygen group stuff here.

Need doxygen group stuff here.

8:48 am

Sean Nash

Need doxygen group stuff here.

Need doxygen group stuff here.

8:47 am

Sean Nash

Why do we need this function? Why not just use the reset function below to start the bootloader?

Why do we need this function? Why not just use the reset function below to start the bootloader?

8:46 am

Sean Nash

This doesn't look like a mode - it looks like a small collection of services - suggest moving to Services folder.

This doesn't look like a mode - it looks like a small collection of services - suggest moving to Services folder.