hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 06 May 2021
1:36 pm

Sean Nash

DEN-7605: Added FPGA compatibility to FPGA POST test. Added skeleton POST for f/w compatibility.

Options
    • -2
    • +25
    ./ModeInitPOST.c
  2. … 1 more file in changeset.
10:27 am

Sean Nash

initBloodPrime() is called every time we transition to blood prime sub-mode.

initBloodPrime() is called every time we transition to blood prime sub-mode.

Wednesday 05 May 2021
7:57 pm

qnguyen  (deleted user)

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

7:48 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Fixed build warnings

Options
    • -0
    • +3
    ./BloodPrime.c
    • -2
    • +3
    ./ConsumableSelfTest.c
    • -4
    • +6
    ./ModePostTreat.c
    • -6
    • +12
    ./ModePreTreat.c
    • -0
    • +12
    ./OperationModes.c
    • -0
    • +1
    ./OperationModes.h
    • -2
    • +3
    ./Prime.c
    • -0
    • +3
    ./Rinseback.c
    • -2
    • +3
    ./SampleWater.c
  10. … 5 more files in changeset.
7:26 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Cleaned up TODO and added alarms

Options
    • -0
    • +1
    ./ConsumableSelfTest.c
    • -1
    • +0
    ./ModeInitPOST.c
    • -2
    • +1
    ./ModePostTreat.c
    • -1
    • +0
    ./ModePreTreat.c
    • -3
    • +2
    ./ModeStandby.c
    • -1
    • +1
    ./OperationModes.c
    • -2
    • +1
    ./PreTreatmentRecirc.c
    • -2
    • +1
    ./Prime.c
    • -1
    • +0
    ./Prime.h
    • -1
    • +1
    ./SampleWater.c
    • -1
    • +1
    ./SampleWater.h
    • -6
    • +3
    ./SelfTests.c
    • -1
    • +2
    ./TreatmentEnd.c
  14. … 5 more files in changeset.
Tuesday 04 May 2021
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 03 May 2021
11:40 am

Sean Nash

Fixed.

Fixed.

11:38 am

Sean Nash

Fixed.

Fixed.

11:37 am

Sean Nash

Copy and paste error. Fixed.

Copy and paste error. Fixed.

10:47 am

qnguyen  (deleted user)

Same as above.

Same as above.

10:46 am

qnguyen  (deleted user)

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

Why do we need to subtract from MAX_ALARM_VOLUME_LEVEL?

10:44 am

qnguyen  (deleted user)

These functions need doxygen description.

These functions need doxygen description.

10:26 am

Sean Nash

I agree, but sometimes feel it helps readability.

I agree, but sometimes feel it helps readability.

10:25 am

Sean Nash

Yes, you are right. I will use fwcommon code.

Yes, you are right. I will use fwcommon code.

10:21 am

Sean Nash

Fixed.

Fixed.

10:20 am

Sean Nash

What declaration?

What declaration?

10:18 am

Sean Nash

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

10:17 am

Sean Nash

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

13 was temporary change for full travel test with Mike. I put it back to 11 for now.

10:15 am

Sean Nash

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

10:14 am

Sean Nash

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

I think it is safer as is. TRUE = 1. If any other value, will be viewed as FALSE and check fails.

10:10 am

pmontazemi  (deleted user)

Parentheses unnecessary.

Parentheses unnecessary.