Modes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-8103: Added dg restarted fault to sample water and reject treatment start if DG not ready

Removed. UI will be the logger, so the clock comes from only one source.

Removed. UI will be the logger, so the clock comes from only one source.

It took around 55 ms for the largest section (.text). I have imposed a maximum size per each CRC calculation, which takes around 7 ms each.

It took around 55 ms for the largest section (.text). I have imposed a maximum size per each CRC calculation, which takes around 7 ms each.

DEN-8103: Addressed code reviews

  1. … 5 more files in changeset.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Done.

Done.

Removed.

Removed.

Done.

Done.

Change PERIOD to PERIODIC?

Change PERIOD to PERIODIC?

How long does this take? We may need to break this loop into smaller pieces and have ModeInitPOST call this function multiple times so that general task does not take too long (> 40ms or so). Other...

How long does this take? We may need to break this loop into smaller pieces and have ModeInitPOST call this function multiple times so that general task does not take too long (> 40ms or so). Otherwise, watchdog will not get pet within its ~50ms window and expire - and also other general and background operations will be blocked until this test is completed.

This enum is getting big. Should we put it in its own .h file (AlarmMgmtSWFaults.h) with same doxygen group name (AlarmManagement) that would be included by this header?

This enum is getting big. Should we put it in its own .h file (AlarmMgmtSWFaults.h) with same doxygen group name (AlarmManagement) that would be included by this header?

For UF, need to accumulate volume deltas or remember where 30 min volume started and then subtract from current volume when 30 minutes is up. Then convert to rate by dividing volume by 30 min.

For UF, need to accumulate volume deltas or remember where 30 min volume started and then subtract from current volume when 30 minutes is up. Then convert to rate by dividing volume by 30 min.

Done.

Done.

Done.

Done.

Neither of these if statements should be executed if treatment is paused (i.e. treatment time is counting down, i.e. we're in dialysis sub-mode of treatment mode and not delivering a saline bolus).

Neither of these if statements should be executed if treatment is paused (i.e. treatment time is counting down, i.e. we're in dialysis sub-mode of treatment mode and not delivering a saline bolus).

Let UI timestamp

Let UI timestamp

The UI will provide this. Firmware will not have this value.

The UI will provide this. Firmware will not have this value.

Need to add a get function for private variable totalSalineVolumeDelivered in Dialysis module.

Need to add a get function for private variable totalSalineVolumeDelivered in Dialysis module.

This should be available from syringe pump driver - getSyringePumpVolumeDelivered().

This should be available from syringe pump driver - getSyringePumpVolumeDelivered().

It doesn't look like this function sends anything to UI - just setting an epoch. Does f/w need to log treatment start/end time or can UI do that from its own clock.

It doesn't look like this function sends anything to UI - just setting an epoch. Does f/w need to log treatment start/end time or can UI do that from its own clock.

Do we not need concentration?

Do we not need concentration?

Same response here.

Same response here.

Data is packaging several pieces of information for both ADA and ADV air bubble detectors, hence, the grammar is plural. The other override functions are commanding on only one of the detectors dep...

Data is packaging several pieces of information for both ADA and ADV air bubble detectors, hence, the grammar is plural. The other override functions are commanding on only one of the detectors depending on the index, hence, the grammar is singular.

DEN-8103: Added alarms for pre-treatment self-tests timeout

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

This will be addressed in DEN-8103.

This will be addressed in DEN-8103.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.