hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 Nov 2021
11:56 pm

Dara Navaei

DEN-11114 tested the modified the reservoir management code

Options
    • -0
    • +3
    ./Dialysis.c
  2. … 3 more files in changeset.
Wednesday 24 Nov 2021
2:47 pm

Sean Nash

DEN-11098: Addressed code review feedback.

Options
    • -14
    • +14
    ./Prime.c
2:45 pm

Sean Nash

Should only set this to true when we know we will accept request.

Should only set this to true when we know we will accept request.

2:37 pm

Sean Nash

Comment should change from 200 to 50.

Comment should change from 200 to 50.

1:37 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11098 Added compiler switch RUN_BLOOD_CIRCUIT_PRIME_AGAIN

Options
    • -2
    • +14
    ./Prime.c
  2. … 1 more file in changeset.
Tuesday 23 Nov 2021
1:32 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Added cases in switch statement to handle prime pause for new saline dialyzer state

Options
    • -1
    • +6
    ./Prime.c
12:32 pm

Dara Navaei

DEN-11114 continued working on the resevoir management

Options
    • -1
    • +1
    ./ConsumableSelfTest.c
    • -3
    • +3
    ./ModePreTreat.c
    • -0
    • +3
    ./ModeTreatmentParams.c
  4. … 6 more files in changeset.
9:59 am

hnguyen  (deleted user)

Done.

Done.

9:57 am

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Removed signalDialOutPumpHardStop since it has not been started

Options
    • -1
    • +0
    ./Prime.c
9:51 am

Sean Nash

You can remove this line here. That pump has not yet been run.

You can remove this line here. That pump has not yet been run.

9:34 am

Hung Nguyen <hnguyen@diality.com>

DEN-11089 the VDO pump is stopped before transition from dialyzer state to wet selftests state

Options
    • -0
    • +1
    ./Prime.c
9:30 am

hnguyen  (deleted user)

Fixed. Before transition from dialyzer state to wet selftests state, the VDO pump should be stopped.

Fixed. Before transition from dialyzer state to wet selftests state, the VDO pump should be stopped.

9:21 am

Sean Nash

Move this line to when prime dialyzer state is completed before we go to wet self tests.

Move this line to when prime dialyzer state is completed before we go to wet self tests.

Monday 22 Nov 2021
6:36 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Correction - dialyzer dialysate bypass priming path uses R1 instead of R2 and dialyzer dialysate priming path uses R2 instead of R1

Options
    • -23
    • +24
    ./Prime.c
  2. … 1 more file in changeset.
Sunday 21 Nov 2021
4:22 pm

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

Options
    • -1
    • +16
    ./ModeTreatment.c
4:22 pm

Dara Navaei

DEN-11114 initial commit of the reservoirs module. Continued with implementing the reservoir management

Options
    • -0
    • +14
    ./Dialysis.c
    • -0
    • +1
    ./Dialysis.h
    • -3
    • +6
    ./ModeTreatment.c
  4. … 5 more files in changeset.
3:53 pm

Sean Nash

DEN-11114: Updated UF control to included estimated UF flow as input.

Options
    • -1
    • +16
    ./ModeTreatment.c
    • -0
    • +1
    ./ModeTreatment.h
  3. … 3 more files in changeset.
Friday 19 Nov 2021
10:23 am

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Incorporated peer review comments

Options
    • -22
    • +15
    ./Prime.c
10:10 am

hnguyen  (deleted user)

Done

Done

10:07 am

hnguyen  (deleted user)

Fixed

Fixed

10:07 am

hnguyen  (deleted user)

I believe reservoir 2 is used. static PRE_TREATMENT_RESERVOIR_MGMT_STATE_T handlePreTreatmentReservoirMgmtStartState( void ) { PRE_TREATMENT_RESERVOIR_MGMT_STATE_T state = PRE_TREATMENT_RESERVOIR_...

I believe reservoir 2 is used.

static PRE_TREATMENT_RESERVOIR_MGMT_STATE_T handlePreTreatmentReservoirMgmtStartState( void )
{
PRE_TREATMENT_RESERVOIR_MGMT_STATE_T state = PRE_TREATMENT_RESERVOIR_MGMT_START_STATE;

if ( TRUE == fillReservoirOneStartRequested )

Unknown macro: { fillReservoirOneStartRequested = FALSE; state = PRE_TREATMENT_RESERVOIR_MGMT_DRAIN_CMD_STATE; cmdSetDGActiveReservoir( DG_RESERVOIR_2 ); }


return state;
}

10:04 am

hnguyen  (deleted user)

Fixed

Fixed

10:04 am

hnguyen  (deleted user)

Done

Done

10:04 am

hnguyen  (deleted user)

Done

Done

Thursday 18 Nov 2021
4:18 pm

Sean Nash

This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here.

This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here.

2:18 pm

Sean Nash

Why reset start time here?

Why reset start time here?

2:11 pm

Sean Nash

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

2:08 pm

Sean Nash

Make it clearer that this is for prime dialyzer state.

Make it clearer that this is for prime dialyzer state.

2:08 pm

Sean Nash

Dialyzer is spelled with a "z" not "s".

Dialyzer is spelled with a "z" not "s".

1:53 pm

Sean Nash

I would rename to something like prime dialyzer stop weight.

I would rename to something like prime dialyzer stop weight.