hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 04 Jan 2022
10:18 am

Behrouz NematiPour

http://dvm-linux02:8060/cru/HD-DEN-10602-1

- Addressed comments

Options
    • -1
    • +1
    ./ModePostTreat.c
    • -1
    • +1
    ./ModeTreatmentParams.c
10:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:15 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:15 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:08 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:07 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:06 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:01 am

Dara Navaei

Done.

Done.

9:55 am

Dara Navaei

Done.

Done.

9:45 am

Dara Navaei

Done.

Done.

9:40 am

hnguyen  (deleted user)

Yes, see #ifdef SKIP_PRIMING currentPrimeState = HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE; #else currentPrimeState = HD_PRIME_WAIT_FOR_USER_START_STATE; #endif

Yes, see
#ifdef SKIP_PRIMING
currentPrimeState = HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE;
#else
currentPrimeState = HD_PRIME_WAIT_FOR_USER_START_STATE;
#endif

Monday 03 Jan 2022
9:45 pm

Dara Navaei

Use () for the multiplication part.

Use () for the multiplication part.

9:34 pm

Dara Navaei

To make sure the order of math operations are correct, we should have () around the items that are multiplied and then divide it to the treatment duration.

To make sure the order of math operations are correct, we should have () around the items that are multiplied and then divide it to the treatment duration.

2:36 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11098 Addressed code review comments

Options
    • -22
    • +22
    ./Prime.c
  2. … 2 more files in changeset.
1:18 pm

Dara Navaei

11:41 am

hnguyen  (deleted user)

Dara, did you add this alarm?

Dara, did you add this alarm?

11:39 am

hnguyen  (deleted user)

Done.

Done.

11:37 am

hnguyen  (deleted user)

Done.

Done.

11:21 am

hnguyen  (deleted user)

Done.

Done.

10:14 am

Dara Navaei

Done.

Done.