hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 02 Feb 2023
12:00 pm

Sean Nash

DEN-14549: Fixed merge from staging merge conflicts.

Options
    • -2
    • +9
    ./ConsumableSelfTest.c
    • -2
    • +21
    ./Dialysis.c
    • -4
    • +16
    ./ModeInitPOST.c
    • -2
    • +15
    ./ModePostTreat.c
    • -2
    • +8
    ./ModeTreatmentParams.c
    • -2
    • +9
    ./PreTreatmentRecirc.c
    • -2
    • +9
    ./Prime.c
    • -2
    • +8
    ./Rinseback.c
    • -2
    • +9
    ./SampleWater.c
    • -27
    • +82
    ./SelfTests.c
    • -2
    • +8
    ./TreatmentStop.c
  12. … 7 more files in changeset.
10:32 am

jtaylor  (deleted user)

Done.

Done.

10:31 am

James Walter Taylor <jtaylor@diality.com>

DEN-14561 Comments

Answered comments from code review

Options
    • -3
    • +3
    ./ModePreTreat.c
    • -1
    • +2
    ./SelfTests.c
10:30 am

jtaylor  (deleted user)

Done.

Done.

Wednesday 01 Feb 2023
4:44 pm

wbracken  (deleted user)

#define?

#define?

4:14 pm

wbracken  (deleted user)

Alignment

Alignment

4:09 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 - returned useLastTrimmerHeaterDC logic

checkpoint, correction.

Options
    • -0
    • +1
    ./ModePreTreat.c
3:24 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 - returned useLastTrimmerHeaterDC logic

Returned logic for trimmer heater

Options
    • -16
    • +23
    ./ModePreTreat.c
2:26 pm

Michael Garthwaite

Merge branch 'DEN-14589-DIAL-211' into develop

Options
    • -1
    • +1
    ./SelfTests.c
  2. … 2 more files in changeset.
2:15 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14651 - Trial simplification of complete state

corrected fillComplete timing, removed TrimmerHeater control change (toggled off/on again over 50ms)

Options
    • -19
    • +11
    ./ModePreTreat.c
1:38 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 Reservoir switching corrected in all modes

An incorrect reservoir reference was shorting R2 one flush cycle.

Options
    • -5
    • +5
    ./ModePreTreat.c
12:30 pm

Darren Cox <darren_m@cox.net>

DEN-14561 Wider wet selftest tolerance. Fix reservoir switch. Fix alarm value for venous pressure.

Options
    • -1
    • +1
    ./Prime.c
    • -3
    • +3
    ./SelfTests.c
11:52 am

jtaylor  (deleted user)

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

Misalignment of terminology. I treated a reservoir "flush" as a fill/drain cycle, ending with the reservoir empty. "flushComplete" had been set accordingly. Test removed.

11:00 am

James Walter Taylor <jtaylor@diality.com>

DEN-14561 - Corrected flush flag state

flush flag expected to be true at the beginning of the fill cycle, with priming disabled. Flush should be true at the end of drain.

Options
    • -8
    • +8
    ./ModePreTreat.c
9:46 am

Michael Garthwaite

DEN-14589: fixed compiler warnings regarding send event

Options
    • -0
    • +1
    ./ConsumableSelfTest.c
    • -0
    • +1
    ./PreTreatmentRecirc.c
Tuesday 31 Jan 2023
6:05 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:03 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 - Final flush correction

Flush complete check removed from drain state.

Options
    • -7
    • +0
    ./ModePreTreat.c
5:01 pm

Dara Navaei

HD-DEN-14547_Incorrect DG Event
HD-DEN-14547_Incorrect DG Event
3:45 pm

jtaylor  (deleted user)

Done. We will want to verify that we don't disable all of the resume fill calls.

Done. We will want to verify that we don't disable all of the resume fill calls.

3:42 pm

jtaylor  (deleted user)

Done.

Done.

3:34 pm

Michael Garthwaite

DEN-14547: fixed HD sub mode changes to no longer be redundant. removed static variable for priorsubmode.

Options
    • -9
    • +1
    ./OperationModes.c
3:34 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./SelfTests.c
3:33 pm

Michael Garthwaite

3:13 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 Reservoir fill selection

Returning switched reservoir selection to orignal pattern.

Options
    • -6
    • +7
    ./ModePreTreat.c
2:55 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14561 Updated reservoir switching

Moved active reservoir marker into local states, reinserted the MGMT complete state change and the SW_CONFIG test volumes

Options
    • -28
    • +50
    ./ModePreTreat.c
2:21 pm

Sean Nash

DEN-14561: fixes to pre-tx fill cycles.

Options
    • -60
    • +30
    ./ModePreTreat.c
1:30 pm

Sean Nash

What does flush complete have to do with draining here?

What does flush complete have to do with draining here?

1:26 pm

Sean Nash

We don't want to signal here if we don't have an air pump.

We don't want to signal here if we don't have an air pump.

1:14 pm

jtaylor  (deleted user)

Done.

Done.

1:05 pm

Sean Nash

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).