hdfirmware / firmware / App

Modes

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 17 Aug 2023
12:54 pm

Michael Garthwaite

DEN-16164: compiler fixes.

Options
    • -1
    • +1
    ./SelfTests.c
11:28 am

Michael Garthwaite

DEN-16164: Code review comments. Changed stop state for handle all alarms for depressurized Inverse logic for setting VBA to Pos B during dry self test failures and ensure HD only does it during dry self test.

Options
    • -8
    • +11
    ./SelfTests.c
10:59 am

jtaylor  (deleted user)

10:58 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Rinseback.c
10:24 am

wbracken  (deleted user) and Sean Nash

9:39 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-15630-vtchd-598-transitions-not-found' into develop

Options
    • -1
    • +1
    ./Dialysis.c
  2. … 5 more files in changeset.
9:35 am

James Walter Taylor <jtaylor@diality.com>

DEN-15630-vtchd-598-transitions-not-found

Added code in pre-treatment prime state to allow pause in start state.

Options
    • -2
    • +6
    ./Prime.c
9:10 am

Sean Nash

8:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:22 am

jtaylor  (deleted user)

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

Wednesday 16 Aug 2023
4:42 pm

Sean Nash

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

3:37 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Simplification.

Options
    • -8
    • +4
    ./Rinseback.c
3:34 pm

dcox  (deleted user)

3:34 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Updated for CR comments.

Options
    • -1
    • +2
    ./Rinseback.c
3:28 pm

jtaylor  (deleted user)

Done.

Done.

3:27 pm

Sean Nash

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

3:26 pm

Sean Nash

Put constant on other side of comparison operator. We only put constant first when using "==".

Put constant on other side of comparison operator. We only put constant first when using "==".

3:14 pm

Sean Nash

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and...

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and rinseback hasn't even started). May be needed for new reconnect patient state as well.
I think it might be simpler/clearer to replace this if with a check for whether BP is running or not. If BP is stopped, we proceed to next if. If BP is running, keep timeouts at zero.

3:03 pm

Sean Nash

2:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Dialysis.c
    • -2
    • +2
    ./ModeTreatment.c
    • -2
    • +2
    ./OperationModes.c
    • -2
    • +2
    ./TreatmentEnd.c
    • -1
    • +1
    ./TreatmentEnd.h
  6. … 3 more files in changeset.
1:59 pm

dcox  (deleted user) , jtaylor  (deleted user) , wbracken  (deleted user) and Vinayakam Mani

1:51 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:47 pm

Sean Nash

DEN-16200: Addressed DEN-16192 re: confirmation of end treatment request sometimes does not go to post tx mode.

Options
    • -9
    • +25
    ./OperationModes.c
12:04 pm

Dara Navaei

HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
11:27 am

Michael Garthwaite

DEN-16164: changed dry self tests to set VBA to Pos B when we have not completed dry self tests. Updated Dry self test stopped state to set VBA to Pos A when venous pressure is normalized after pressure tests.

Options
    • -2
    • +22
    ./SelfTests.c
9:36 am

Sean Nash

Merge branch 'DEN-16200-syringe-pump-stuck-in-priming-state' into develop

Options
    • -2
    • +3
    ./Dialysis.c
  2. … 1 more file in changeset.
9:31 am

Sean Nash

DEN-16200: Addressed code review comment. Addressed DEN-16229 re: Heparin not dispensing after alarm w/ blood recirc.

Options
    • -2
    • +3
    ./Dialysis.c
    • -1
    • +1
    ./ModeTreatment.c
  3. … 1 more file in changeset.
9:02 am

Sean Nash

Done.

Done.

9:01 am

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Typo. Corrected display enable logic.

Options
    • -1
    • +1
    ./Rinseback.c
Tuesday 15 Aug 2023
6:45 pm

wbracken  (deleted user)

Add syringePumpStateStartTime to header.

Add syringePumpStateStartTime to header.