Activity hdfirmware/firmware/App/Modes

4:45 pm

Sean Nash

More
Re: HD-DEN-16680-2
commented on review

We didn't have this before?

3:29 pm

Dara Navaei

More
HD-DEN-16680-2
started review

HD-DEN-16680_P1B Inlet Water Shutdown During Heat Disinfect Staging

10:53 am

Sean Nash

Why is bootloader executing in a different mode than app? Is that necessary? How will mode switch back to user when jumping to app?

1:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:48 pm

Vinayakam Mani

More
Re: HD-DEN-16778-1
replied to Sean Nash

Once it goes into prime pause state -> say, user removes the clamping and resume the priming -> again this state executes to check the clamping condition. Now, venous pressure is in range and raw f...

Once it goes into prime pause state -> say, user removes the clamping and resume the priming -> again this state executes to check the clamping condition. Now, venous pressure is in range and raw flow rate more than minimum, we get into else state with last set flag ( primeDialysateOcclusionDetected) and change the priming state back to blood priming initial states.

1:17 pm

Sean Nash

More
Re: HD-DEN-16778-1
commented on review

Alarm above has stop property. So triggering alarm will take us out of this state and go to Prime Pause state. So this else will never happen I think.

1:12 pm

Sean Nash

More
Re: HD-DEN-16778-1
commented on review

This looks like a threshold. So name should start with MIN or MAX.

11:55 am

Vinayakam Mani

More
Re: HD-DEN-16565-1
commented on review

Bootloader seems to be executed in supervisory mode. if so, the current allocated stack for supervisory mode is 1K (if we merge into existing HD/DG firmware). we may need to watch for supervisory m...

Bootloader seems to be executed in supervisory mode. if so, the current allocated stack for supervisory mode is 1K (if we merge into existing HD/DG firmware). we may need to watch for supervisory mode stack size, in case boot loader consumes more that 1K?

11:48 am

Vinayakam Mani

More
Re: HD-DEN-16565-1
commented on review

the second value is 0x00 or 0xFFFFFFFF? The bootloader checks the value is not equal to 0xFFFFFFFF, if so, the valid application is not found, and firmware needs to be updated.

the second value is 0x00 or 0xFFFFFFFF?

The bootloader checks the value is not equal to 0xFFFFFFFF, if so, the valid application is not found, and firmware needs to be updated.

11:27 am

Vinayakam Mani

More
Re: HD-DEN-16565-1
commented on review

Looks to be memory overflow to be occurred. src-> pointing the buffer of 4 bytes length. bytes-> mentioning 16 bytes length. g_pulUpdateSuccess[] should be allocated more than the current size. Als...

Looks to be memory overflow to be occurred. src-> pointing the buffer of 4 bytes length. bytes-> mentioning 16 bytes length. g_pulUpdateSuccess[] should be allocated more than the current size. Also, Do we need to typecast "(uint32_t) bytes", since the api mentioning (uint8_t)?

Fapi_StatusType Fapi_issueProgrammingCommand(
uint32_t *pu32StartAddress,
uint8_t *pu8DataBuffer,
uint8_t u8DataBufferSizeInBytes,
uint8_t *pu8EccBuffer,
uint8_t u8EccBufferSizeInBytes,
Fapi_FlashProgrammingCommandType oMode)

1:27 pm