hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 29 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 20 May 2021
11:35 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Shorten a code line

Options
    • -2
    • +4
    ./Integrity.c
11:13 am

qnguyen  (deleted user)

Removed. UI will be the logger, so the clock comes from only one source.

Removed. UI will be the logger, so the clock comes from only one source.

11:13 am

qnguyen  (deleted user)

It took around 55 ms for the largest section (.text). I have imposed a maximum size per each CRC calculation, which takes around 7 ms each.

It took around 55 ms for the largest section (.text). I have imposed a maximum size per each CRC calculation, which takes around 7 ms each.

11:10 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Addressed code reviews

Options
    • -133
    • +2
    ./AlarmMgmt.h
    • -0
    • +162
    ./AlarmMgmtSWFaults.h
    • -24
    • +51
    ./Integrity.c
    • -3
    • +3
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h
  6. … 6 more files in changeset.
10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 19 May 2021
5:18 pm

qnguyen  (deleted user)

Done.

Done.

5:18 pm

qnguyen  (deleted user)

Done.

Done.

5:18 pm

qnguyen  (deleted user)

Removed.

Removed.

5:12 pm

qnguyen  (deleted user)

Done.

Done.

4:57 pm

Sean Nash

Change PERIOD to PERIODIC?

Change PERIOD to PERIODIC?

4:55 pm

Sean Nash

How long does this take? We may need to break this loop into smaller pieces and have ModeInitPOST call this function multiple times so that general task does not take too long (> 40ms or so). Other...

How long does this take? We may need to break this loop into smaller pieces and have ModeInitPOST call this function multiple times so that general task does not take too long (> 40ms or so). Otherwise, watchdog will not get pet within its ~50ms window and expire - and also other general and background operations will be blocked until this test is completed.

4:49 pm

Sean Nash

This enum is getting big. Should we put it in its own .h file (AlarmMgmtSWFaults.h) with same doxygen group name (AlarmManagement) that would be included by this header?

This enum is getting big. Should we put it in its own .h file (AlarmMgmtSWFaults.h) with same doxygen group name (AlarmManagement) that would be included by this header?

4:42 pm

Sean Nash

For UF, need to accumulate volume deltas or remember where 30 min volume started and then subtract from current volume when 30 minutes is up. Then convert to rate by dividing volume by 30 min.

For UF, need to accumulate volume deltas or remember where 30 min volume started and then subtract from current volume when 30 minutes is up. Then convert to rate by dividing volume by 30 min.

4:38 pm

qnguyen  (deleted user)

Done.

Done.

4:38 pm

qnguyen  (deleted user)

Done.

Done.

4:35 pm

Sean Nash

Neither of these if statements should be executed if treatment is paused (i.e. treatment time is counting down, i.e. we're in dialysis sub-mode of treatment mode and not delivering a saline bolus).

Neither of these if statements should be executed if treatment is paused (i.e. treatment time is counting down, i.e. we're in dialysis sub-mode of treatment mode and not delivering a saline bolus).

4:29 pm

Sean Nash

Let UI timestamp

Let UI timestamp

4:09 pm

qnguyen  (deleted user)

The UI will provide this. Firmware will not have this value.

The UI will provide this. Firmware will not have this value.

3:46 pm

Sean Nash

Need to add a get function for private variable totalSalineVolumeDelivered in Dialysis module.

Need to add a get function for private variable totalSalineVolumeDelivered in Dialysis module.

3:44 pm

Sean Nash

This should be available from syringe pump driver - getSyringePumpVolumeDelivered().

This should be available from syringe pump driver - getSyringePumpVolumeDelivered().

3:41 pm

Sean Nash

It doesn't look like this function sends anything to UI - just setting an epoch. Does f/w need to log treatment start/end time or can UI do that from its own clock.

It doesn't look like this function sends anything to UI - just setting an epoch. Does f/w need to log treatment start/end time or can UI do that from its own clock.

3:39 pm

Sean Nash

Do we not need concentration?

Do we not need concentration?

10:59 am

pmontazemi  (deleted user)

Same response here.

Same response here.

10:59 am

pmontazemi  (deleted user)

Data is packaging several pieces of information for both ADA and ADV air bubble detectors, hence, the grammar is plural. The other override functions are commanding on only one of the detectors dep...

Data is packaging several pieces of information for both ADA and ADV air bubble detectors, hence, the grammar is plural. The other override functions are commanding on only one of the detectors depending on the index, hence, the grammar is singular.

10:41 am

qnguyen  (deleted user)

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

10:41 am

qnguyen  (deleted user)

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Tuesday 18 May 2021
3:25 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: Fixed payload.index bug

Options
    • -1
    • +1
    ./SystemComm.c
    • -1
    • +1
    ./SystemCommMessages.c
2:55 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: made function names consistent with number of detectors

Options
    • -2
    • +2
    ./SystemComm.c
    • -3
    • +3
    ./SystemCommMessages.c
    • -3
    • +3
    ./SystemCommMessages.h
  4. … 1 more file in changeset.
1:14 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: Changed override function name and message data type to match actual data

Options
    • -1
    • +1
    ./SystemComm.c
    • -6
    • +6
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h