hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Jun 2021
6:05 pm

Sean Nash

Fixed build flags.

Options
    • -2
    • +2
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
10:55 am

qnguyen  (deleted user)

Removed this extra flag and used alarm status noNewTreatment flag.

Removed this extra flag and used alarm status noNewTreatment flag.

10:54 am

qnguyen  (deleted user)

Removed this extra flag.

Removed this extra flag.

10:52 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Addressed code review

Options
    • -15
    • +7
    ./AlarmMgmt.c
    • -1
    • +1
    ./AlarmMgmt.h
  3. … 1 more file in changeset.
10:51 am

qnguyen  (deleted user)

Done.

Done.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:27 am

qnguyen  (deleted user)

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface. Sample water sub-mode has to check before DG started.

Yes, and we checked for DG restarted (after it has started by HD) in DGInterface.
Sample water sub-mode has to check before DG started.

9:57 am

Sean Nash

Merge branch 'DEN-7605-hd_dg_dev-self-tests' into develop

Options
    • -5
    • +57
    ./AlarmMgmt.c
    • -1
    • +2
    ./AlarmMgmt.h
    • -10
    • +12
    ./FPGA.c
    • -1
    • +1
    ./FPGA.h
  5. … 2 more files in changeset.
9:55 am

Sean Nash

DEN-7605: Added POST test for alarm audio.

Options
    • -5
    • +57
    ./AlarmMgmt.c
    • -1
    • +2
    ./AlarmMgmt.h
    • -10
    • +12
    ./FPGA.c
    • -1
    • +1
    ./FPGA.h
  5. … 3 more files in changeset.
9:07 am

Sean Nash

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

Looks like you are latching the noEndTreatment status. Maybe we can have that status be latching so we don't need two flags.

9:03 am

Sean Nash

Is this different than alarmStatus.noNewTreatment?

Is this different than alarmStatus.noNewTreatment?

9:01 am

Sean Nash

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

Shouldn't this be checked more broadly (not just in water sample sub-mode)?

12:07 am

Quang Nguyen <qnguyen@diality.com>

DEN-8679: Implemented system comm msg for treatment log msgs

Options
    • -1
    • +34
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
Saturday 29 May 2021
1:06 am

qnguyen  (deleted user)

Removed.

Removed.

1:03 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Moved integrity module to fwcommon

Options
    • -1
    • +0
    ./AlarmMgmtSWFaults.h
    • -3
    • +3
    ./FPGA.c
    • -135
    • +0
    ./Integrity.c
    • -40
    • +0
    ./Integrity.h
Friday 28 May 2021
3:32 pm

Sean Nash

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have...

I think rather than 37, these should be the lowest high priority rank (i.e. 49) so we can add new alarms and not have to renumber these. Also, I think the range for high priority alarms should have room for more than 50 alarms. Maybe high priority could be 1..499, medium priority 500..599, and low priority 600..699.

3:23 pm

Sean Nash

Dara, do we need these handlers or not?

Dara, do we need these handlers or not?

3:23 pm

Sean Nash

We should delete this dead code as well.

We should delete this dead code as well.

10:34 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:27 am

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Implementation for alarm list

Options
    • -8
    • +22
    ./AlarmMgmt.c
Thursday 27 May 2021
4:14 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-8534: Initial push

Options
    • -0
    • +1
    ./AlarmMgmt.h
10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Wednesday 26 May 2021
6:40 pm

Quang Nguyen <qnguyen@diality.com>

DEN-8103: Initial alarm list implementation

Options
    • -20
    • +35
    ./AlarmMgmt.c
    • -1
    • +2
    ./AlarmMgmt.h
    • -0
    • +4
    ./SystemComm.c
    • -22
    • +98
    ./SystemCommMessages.c
    • -0
    • +6
    ./SystemCommMessages.h
  6. … 1 more file in changeset.
11:22 am

Dara Navaei

11:22 am

Dara Navaei

Tuesday 25 May 2021
2:30 pm

qnguyen  (deleted user) and Sean Nash

1:04 pm

Sean Nash

Fixed merge conflicts.

Options
    • -21
    • +33
    ./SystemComm.c
    • -5
    • +161
    ./SystemCommMessages.c
    • -0
    • +15
    ./SystemCommMessages.h
  4. … 5 more files in changeset.
12:53 pm

Sean Nash

DEN-7605: Added support for UI clock sync.

Options
    • -0
    • +4
    ./SystemComm.c
    • -5
    • +50
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
  4. … 2 more files in changeset.