Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13834 merged staging

  1. … 6 more files in changeset.
common and fwcommon repos are covered in the 13598 DG code review so not needed here.

common and fwcommon repos are covered in the 13598 DG code review so not needed here.

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this...

Bill, I think this #ifndef is here because this test will fail if you are debugging and ever stop for a break point (FPGA timer keeps going but processor timer stops). So the idea here is that this test only runs on a release build.

DEN-13460 addressed the code review comments

  1. … 4 more files in changeset.
Done.

Done.

It is implemented.

It is implemented.

Done.

Done.

Done.

Done.

Done.

Done.

These variables will be deleted.

These variables will be deleted.

Done.

Done.

The buffer has been increased in the DEN-13903.

The buffer has been increased in the DEN-13903.

Done.

Done.

Merge branch 'DEN-13598-dg_hd_dev-sprint-77-fw-dong' into develop

DEN-13598: Add code for FPGA clock speed checking

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

DEN-13834 changed the service and disinfect alarms to reject reasons. Added retries for the blood leak zero command

  1. … 4 more files in changeset.
Fixed merge conflicts.

  1. … 3 more files in changeset.
DEN-13598: Removed test code.

  1. … 1 more file in changeset.
Merge branch 'DEN-13903-s80-mg-DIAL-204' into develop

  1. … 7 more files in changeset.
DEN-13903: DIAL-204: Fixes. Linking. Removal of warnings.

  1. … 3 more files in changeset.
DEN-13903: DIAL-204: Implemented set PWM for all 3 HD pumps.

  1. … 6 more files in changeset.
Merged DEN-13834

  1. … 3 more files in changeset.
Update header.

Update header.

Update header?

Update header?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should 365 be #define? Why changed from #define to static const U32?

Should 365 be #define? Why changed from #define to static const U32?

Should 250 be #define?

Should 250 be #define?

Should struct members be aligned?

Should struct members be aligned?

DEN-13834 updated the code

  1. … 8 more files in changeset.