Services

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14561

Code review updates

  1. … 1 more file in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Need to verify SRS and AlarmsDef.h are in sync.

Need to verify SRS and AlarmsDef.h are in sync.

Alignment

Alignment

Comments line up but the values don't?

Comments line up but the values don't?

Done.

Done.

Done.

Done.

Extra white space.

Extra white space.

Should align

Should align

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Updated to 600.

Updated to 600.

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

So R2 fill was 1100 and you say it ended up at 500. Would be 800 if keep same at 1100. If we change to 600, would end around 300 as you say - I think that's right.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merge branch 'DEN-14328-hd-event-issues' into develop

  1. … 4 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 10 more files in changeset.
Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

Updated for only reservoir 2 fill state.

Updated for only reservoir 2 fill state.

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first. Also, if we go to fill state like this, wi...

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first.
Also, if we go to fill state like this, will it do a flush or a normal fill? I think it will do a flush fill since flushed flag is still FALSE.

Remove extra blank line.

Remove extra blank line.

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

We should initialize these with a loop iterating through each reservoir (in case a reservoir is added/removed at some point).

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

This should probably be 600 since we'll only be transferring 300 to R1 in wet self-tests.

Alignment

Alignment

DEN-14559 updated the code to be able to run POST requested by the Dialin user

  1. … 10 more files in changeset.
Merge branch 'staging' into DEN-14549-system-fault-after-resuming-heparin-then-starting-saline-bolus-during-treatment

  1. … 2 more files in changeset.
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-14549: Added function to see if an alarm condition is detected. Added a function to determine whether A/C power loss condition is detected and used them where needed.

  1. … 5 more files in changeset.