hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Aug 2023
10:44 am

Michael Garthwaite

DEN-14706: code review comments.

Options
    • -1
    • +0
    ./SystemComm.c
10:43 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

DEN-14706: changed override condition for pending ack

Options
    • -2
    • +1
    ./SystemComm.c
10:20 am

wbracken  (deleted user) and Sean Nash

10:20 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:16 am

Sean Nash

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

9:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:00 am

Michael Garthwaite

DEN-16164: Removed reservoir weight check in fill settle state

Options
    • -1
    • +1
    ./Reservoirs.c
Thursday 17 Aug 2023
6:45 pm

Michael Garthwaite

DEN-14706: HD pending ACK override message handling and implementation.

Options
    • -3
    • +64
    ./SystemComm.c
    • -1
    • +3
    ./SystemComm.h
    • -0
    • +32
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
6:05 pm

Dara Navaei

HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
2:21 pm

Michael Garthwaite

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

1:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

wbracken  (deleted user)

Add dryPressureTestsCompleted to header.

Add dryPressureTestsCompleted to header.

1:01 pm

Sean Nash

12:56 pm

Michael Garthwaite

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

12:55 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

9:39 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-15630-vtchd-598-transitions-not-found' into develop

Options
    • -2
    • +35
    ./SystemCommMessages.c
    • -2
    • +5
    ./SystemCommMessages.h
  3. … 4 more files in changeset.
Wednesday 16 Aug 2023
3:27 pm

Sean Nash

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

3:26 pm

Sean Nash

Put constant on other side of comparison operator. We only put constant first when using "==".

Put constant on other side of comparison operator. We only put constant first when using "==".

2:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Reservoirs.c
  2. … 7 more files in changeset.
1:59 pm

dcox  (deleted user) , jtaylor  (deleted user) , wbracken  (deleted user) and Vinayakam Mani

1:51 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:04 pm

Dara Navaei

HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
10:43 am

Sean Nash

DEN-16200: Removed obsolete #define.

Options
    • -1
    • +0
    ./Reservoirs.c
10:30 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
10:25 am

jtaylor  (deleted user)

9:57 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-15996-over-ride-commands-duplicates-the-id-msg_id_valves_states_publish_interval_override' into staging

Options
    • -1
    • +1
    ./SystemComm.c
9:54 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +2
    ./SystemCommMessages.c
    • -2
    • +2
    ./SystemCommMessages.h