hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit: 29 Apr
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

Done.

Done.

6:04 pm

Vinayakam Mani

Done.

Done.

5:02 pm

jtaylor  (deleted user) and Michael Garthwaite

1:45 pm

Sean Nash

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface tha...

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

1:38 pm

Sean Nash

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

12:35 pm

Michael Garthwaite

12:05 pm

Dara Navaei

HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
10:15 am

wbracken  (deleted user) and jtaylor  (deleted user)

9:54 am

jtaylor  (deleted user)

Friday 18 Aug 2023
12:04 pm

Dara Navaei

HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
11:03 am

Sean Nash

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:43 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:20 am

wbracken  (deleted user) and Sean Nash

10:20 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:16 am

Sean Nash

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

9:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 17 Aug 2023
6:05 pm

Dara Navaei

HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
2:21 pm

Michael Garthwaite

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

1:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

wbracken  (deleted user)

Add dryPressureTestsCompleted to header.

Add dryPressureTestsCompleted to header.

1:01 pm

Sean Nash

12:56 pm

Michael Garthwaite

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

12:55 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

Wednesday 16 Aug 2023
3:27 pm

Sean Nash

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

3:26 pm

Sean Nash

Put constant on other side of comparison operator. We only put constant first when using "==".

Put constant on other side of comparison operator. We only put constant first when using "==".

1:59 pm

dcox  (deleted user) , jtaylor  (deleted user) , wbracken  (deleted user) and Vinayakam Mani