hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 5
Total Committers: 16
Last Commit: 10 Jun
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Aug 2023
11:09 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-16245-hd.valves.cmd_set_hd_valve_current_override-rejects-any-value' into develop

# Conflicts:

# firmware/App/HDCommon.h

Options
    • -2
    • +0
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
11:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Michael Garthwaite

Merge branch 'DIAL-278-fan-pwm-override' into develop

Options
    • -1
    • +33
    ./SystemCommMessages.c
    • -1
    • +4
    ./SystemCommMessages.h
9:29 am

Vinayakam Mani

DEN-16093 merge in to develop

Options
    • -0
    • +24
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
  3. … 2 more files in changeset.
Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

Done.

Done.

6:04 pm

Vinayakam Mani

Done.

Done.

6:01 pm

Vinayakam Mani

DEN-16093 DG park concetrate pump command response handled

Options
    • -1
    • +1
    ./SystemCommMessages.c
  2. … 1 more file in changeset.
5:02 pm

jtaylor  (deleted user) and Michael Garthwaite

1:45 pm

Sean Nash

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface tha...

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

1:38 pm

Sean Nash

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

12:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemComm.c
    • -2
    • +2
    ./SystemComm.h
    • -1
    • +1
    ./SystemCommMessages.c
    • -1
    • +1
    ./SystemCommMessages.h
12:35 pm

Michael Garthwaite

12:05 pm

Dara Navaei

HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
11:06 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-16245 Valve override valide for both RELEASE and DEBUG

Options
    • -2
    • +0
    ./SystemCommMessages.c
10:15 am

wbracken  (deleted user) and jtaylor  (deleted user)

9:54 am

jtaylor  (deleted user)

9:00 am

Vinayakam Mani

DEN-16093-added DG park concentrate pumps

Options
    • -0
    • +24
    ./SystemCommMessages.c
    • -0
    • +3
    ./SystemCommMessages.h
  3. … 3 more files in changeset.
Friday 18 Aug 2023
1:31 pm

Sean Nash

Merge branch 'DENBUG-59-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

Options
    • -16
    • +13
    ./SystemCommMessages.c
1:27 pm

Sean Nash

DENBUG-59: Fixed expected msg payload length for a trigger alarm msg.

Options
    • -16
    • +13
    ./SystemCommMessages.c
12:04 pm

Dara Navaei

HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
11:03 am

Sean Nash

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Michael Garthwaite

DEN-14706: code review comments.

Options
    • -1
    • +0
    ./SystemComm.c
10:43 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

DEN-14706: changed override condition for pending ack

Options
    • -2
    • +1
    ./SystemComm.c
10:20 am

wbracken  (deleted user) and Sean Nash

10:20 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:16 am

Sean Nash

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

Override should be OR'd with timeout only. Used should have to be true even if override > 0.