hdfirmware / firmware / App

Services

Clone Tools

Stats

Commits this week: 3
Total Committers: 16
Last Commit: 08 Jun
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 08 Jan 2024
1:04 pm

Vinayakam Mani

The removed code changes are dead code due to condition of "if" condition check at top level ( ALARM_TABLE[ a ].alarmClearOnly). these alarms have property of 'clear only' as 'TRUE" in the alarm ta...

The removed code changes are dead code due to condition of "if" condition check at top level ( ALARM_TABLE[ a ].alarmClearOnly). these alarms have property of 'clear only' as 'TRUE" in the alarm table. hence condition always be false and the removed code changes never executed.

8:59 am

Sean Nash

8:59 am

Sean Nash

8:58 am

Sean Nash

8:58 am

Sean Nash

8:56 am

Dara Navaei

Why was this block removed? We do not need to check of the empty bottles alarms anymore?

Why was this block removed? We do not need to check of the empty bottles alarms anymore?

8:52 am

Dara Navaei

HD-DEN-16595_Vectorcast Unit And Integration Testing
HD-DEN-16595_Vectorcast Unit And Integration Testing
8:52 am

Dara Navaei

HD-DEN-16595_Vectorcast Unit And Integration Testing
HD-DEN-16595_Vectorcast Unit And Integration Testing
Friday 22 Dec 2023
9:31 am

Sean Nash

9:29 am

Sean Nash

Do we really want to use a whole flash sector for a flag? I thought bootloader was going to talk to UI to determine whether an update was in progress?

Do we really want to use a whole flash sector for a flag? I thought bootloader was going to talk to UI to determine whether an update was in progress?

9:09 am

Sean Nash

What is this for?

What is this for?

9:08 am

Sean Nash

This is adding conversion to binary step post-build, correct? Are we losing the alarm check here?

This is adding conversion to binary step post-build, correct? Are we losing the alarm check here?

9:06 am

Sean Nash

Don't make changes outside of user code sections.

Don't make changes outside of user code sections.

9:05 am

Sean Nash

So app start address is offset by 64K. Assuming that is plenty of room for bootloader but we should check. Also, have we checked that the first 64K of Flash memory is discreet sector-wise? We do no...

So app start address is offset by 64K. Assuming that is plenty of room for bootloader but we should check.
Also, have we checked that the first 64K of Flash memory is discreet sector-wise? We do not want bootloader and app sharing a sector.

9:01 am

Sean Nash

Why aren't each of these messages calling their own handler function? They appear to exist in SystemCommMessages.c so I believe that was the intent.

Why aren't each of these messages calling their own handler function? They appear to exist in SystemCommMessages.c so I believe that was the intent.

8:59 am

Sean Nash

Should we use new reboot function in Update.c?

Should we use new reboot function in Update.c?

8:58 am

Sean Nash

Spaces in (). Be explicit on BOOL conditions.

Spaces in (). Be explicit on BOOL conditions.

8:58 am

Sean Nash

Spaces in ().

Spaces in ().

8:57 am

Sean Nash

Why not call the reboot function in Update.c?

Why not call the reboot function in Update.c?

8:57 am

Sean Nash

Spaces inside (). Be explicit with BOOL conditions.

Spaces inside (). Be explicit with BOOL conditions.

8:57 am

Sean Nash

Spaces inside (). Use ternary to set to TRUE or FALSE explicitly.

Spaces inside (). Use ternary to set to TRUE or FALSE explicitly.

8:56 am

Sean Nash

Where is this being called?

Where is this being called?

8:55 am

Sean Nash

This message will not get sent immediately - it is only queued. Reset will occur before transmit.

This message will not get sent immediately - it is only queued. Reset will occur before transmit.

8:54 am

Sean Nash

Where is this called?

Where is this called?

8:53 am

Sean Nash

I don't see SystemComm calling this or reboot function. Why are they here?

I don't see SystemComm calling this or reboot function. Why are they here?

8:51 am

Sean Nash

These changes look wrong. This is UI comm check.

These changes look wrong. This is UI comm check.

8:49 am

Sean Nash

Need doxygen group stuff here.

Need doxygen group stuff here.

8:48 am

Sean Nash

Need doxygen group stuff here.

Need doxygen group stuff here.

8:47 am

Sean Nash

Why do we need this function? Why not just use the reset function below to start the bootloader?

Why do we need this function? Why not just use the reset function below to start the bootloader?

8:46 am

Sean Nash

This doesn't look like a mode - it looks like a small collection of services - suggest moving to Services folder.

This doesn't look like a mode - it looks like a small collection of services - suggest moving to Services folder.