Tasks

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-13598: Code review updates

DEN-13460 addressed the code review comments

  1. … 4 more files in changeset.
Done.

Done.

It is implemented.

It is implemented.

Done.

Done.

Done.

Done.

Done.

Done.

These variables will be deleted.

These variables will be deleted.

Done.

Done.

The buffer has been increased in the DEN-13903.

The buffer has been increased in the DEN-13903.

Done.

Done.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

Add bloodLeakEmbModeHasZeroBeenRqustd to header.

Fixed merge conflicts.

  1. … 5 more files in changeset.
DEN-13598: Removed test code.

  1. … 2 more files in changeset.
Update header.

Update header.

Update header?

Update header?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should this be #elseif? Can DG AND HD both be defined or neither?

Should 365 be #define? Why changed from #define to static const U32?

Should 365 be #define? Why changed from #define to static const U32?

Should 250 be #define?

Should 250 be #define?

Should struct members be aligned?

Should struct members be aligned?

DEN-13598: Add persistence alarm using Windowscount for FPGA clock-spedd check

  1. … 2 more files in changeset.
Is this indentation correct?

Is this indentation correct?

How is the event calibration update record being used?

How is the event calibration update record being used?

HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3
What is this comment for?

What is this comment for?

Remove

Remove

Remove if not needed.

Remove if not needed.

DEN-13598: Add code for RAM error and FPGA clock speed.

  1. … 2 more files in changeset.
Update header

Update header

Remove extra blank line.

Remove extra blank line.