Activity hdfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 19 May 2021

10:55 am

Quang Nguyen <qnguyen@diality.com>

More
e63c542
changed 4 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 354 more HD-DEN-8103-1

DEN-8103: Added alarms for pre-treatment self-tests timeout

- -1
- +13
./Modes/ModePostTreat.c
- History
- Source
- Diff
./Modes/ModePostTreat.c
- -0
- +2
./Modes/ModePostTreat.h
- History
- Source
- Diff
./Modes/ModePostTreat.h
- -0
- +2
./Modes/ModeTreatment.c
- History
- Source
- Diff
./Modes/ModeTreatment.c
- -2
- +18
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c

10:41 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
commented on review

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

10:41 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
commented on review

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Recommend remove 'S' from "BUBBLES" to be consistent with other messages.

Tuesday 18 May 2021

3:25 pm

Peman Montazemi <pmontazemi@diality.com>

More
ca3dfb4
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 356 more HD-DEN-7860-1

DEN-7860: Fixed payload.index bug

- -1
- +1
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -1
- +1
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c

2:55 pm

Peman Montazemi <pmontazemi@diality.com>

More
757fb5d
changed 4 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 356 more HD-DEN-7860-1

DEN-7860: made function names consistent with number of detectors

- -1
- +1
./Controllers/Bubble.c
- History
- Source
- Diff
./Controllers/Bubble.c
- -2
- +2
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -3
- +3
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -3
- +3
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

1:14 pm

Peman Montazemi <pmontazemi@diality.com>

More
6a690d6
changed 3 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 356 more HD-DEN-7860-1

DEN-7860: Changed override function name and message data type to match actual data

- -1
- +1
./Services/SystemComm.c
- History
- Source
- Diff
./Services/SystemComm.c
- -6
- +6
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -1
- +1
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

10:42 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

This will be addressed in DEN-8103.

This will be addressed in DEN-8103.

10:40 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

qnguyen (deleted user)

More
Re: HD-DEN-7605-2
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

I don't see changes to HD fluid leak. DG fluid leak function header looks ok as is. RESOLVED in CODE WALKTHROUGH.

I don't see changes to HD fluid leak. DG fluid leak function header looks ok as is. RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Peman Montazemi <pmontazemi@diality.com>

More
1c31145
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 356 more HD-DEN-7860-1

DEN-7860: Addressed code review comments

- -1
- +0
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c

10:33 am

pmontazemi (deleted user)

More
Re: HD-DEN-7860-1
replied to qnguyen (deleted user)

Addressed.

Addressed.

10:32 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:09 am

qnguyen (deleted user)

More
HD-DEN-8103-1
started review

HD-DEN-8103_DG HD Dev Alarm Design

HD-DEN-8103_DG HD Dev Alarm Design

9:36 am

qnguyen (deleted user)

More
Re: HD-DEN-7860-1
commented on review

Remove extra line.

Remove extra line.

9:02 am

Peman Montazemi <pmontazemi@diality.com>

More
8cfb168
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 356 more HD-DEN-7860-1

DEN-7860: Addressed code review comments

- -2
- +2
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c

9:00 am

pmontazemi (deleted user)

More
Re: HD-DEN-7860-1
replied to Sean Nash

Addressed.

Addressed.

8:45 am

Sean Nash

More
Re: HD-DEN-7860-1
replied to pmontazemi (deleted user)

payload is of type TEST_OVERRIDE_ARRAY_PAYLOAD_T (12 bytes). TEST_OVERRIDE_PAYLOAD_T (used below) is only 8 bytes. Change below to array version of test payload type.

payload is of type TEST_OVERRIDE_ARRAY_PAYLOAD_T (12 bytes). TEST_OVERRIDE_PAYLOAD_T (used below) is only 8 bytes. Change below to array version of test payload type.

Monday 17 May 2021

10:36 pm

Quang Nguyen <qnguyen@diality.com>

More
84bb866
changed 10 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 354 more HD-DEN-8103-1

DEN-8103: Added treatment log data

- -2
- +5
./Drivers/Battery.c
- History
- Source
- Diff
./Drivers/Battery.c
- -1
- +1
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h
- -3
- +1
./Modes/Dialysis.c
- History
- Source
- Diff
./Modes/Dialysis.c
- -0
- +53
./Modes/ModePostTreat.c
- History
- Source
- Diff
./Modes/ModePostTreat.c
- -0
- +75
./Modes/ModeTreatment.c
- History
- Source
- Diff
./Modes/ModeTreatment.c
- -0
- +12
./Modes/ModeTreatment.h
- History
- Source
- Diff
./Modes/ModeTreatment.h
- -0
- +3
./Modes/PreTreatmentRecirc.c
- History
- Source
- Diff
./Modes/PreTreatmentRecirc.c
- -1
- +12
./Services/Integrity.c
- History
- Source
- Diff
./Services/Integrity.c
- -1
- +26
./Services/SystemCommMessages.c
- History
- Source
- Diff
./Services/SystemCommMessages.c
- -0
- +3
./Services/SystemCommMessages.h
- History
- Source
- Diff
./Services/SystemCommMessages.h

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-12 15:57 -0800