hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Nov 2021
8:48 pm

Dara Navaei

DEN-9480 addressed the code review comments

Options
    • -5
    • +1
    ./Controllers/Valves.c
    • -4
    • +2
    ./Modes/ModeInitPOST.c
    • -0
    • +4
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
8:44 pm

Dara Navaei

I removed it.

I removed it.

8:40 pm

Dara Navaei

Removed the code.

Removed the code.

8:40 pm

Dara Navaei

Done.

Done.

8:39 pm

Dara Navaei

Done.

Done.

8:38 pm

Dara Navaei

Done.

Done.

8:37 pm

Dara Navaei

Fixed the code.

Fixed the code.

8:33 pm

Dara Navaei

I added the command.

I added the command.

2:53 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
2:53 pm

Sean Nash

Disabled UI comm t/o alarm.

Options
    • -1
    • +1
    ./HDCommon.h
2:44 pm

Sean Nash

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

Options
    • -0
    • +1
    ./HDCommon.h
    • -2
    • +4
    ./Services/SystemComm.c
2:44 pm

Sean Nash

Disable pre-treatment build flags for Eliza.

Options
    • -7
    • +7
    ./HDCommon.h
2:42 pm

Sean Nash

DEN-9906: Added build switch for disabling UI comm timeout alarm.

Options
    • -0
    • +1
    ./HDCommon.h
    • -2
    • +4
    ./Services/SystemComm.c
2:31 pm

Sean Nash

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

Options
    • -9
    • +27
    ./Controllers/DGInterface.c
    • -1
    • +2
    ./Controllers/DGInterface.h
    • -9
    • +35
    ./Controllers/DialInFlow.c
    • -2
    • +1
    ./Controllers/DialInFlow.h
    • -5
    • +7
    ./Controllers/SyringePump.c
    • -2
    • +2
    ./Controllers/Voltages.c
    • -4
    • +4
    ./Modes/Dialysis.c
    • -2
    • +1
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Tasks/TaskGeneral.c
    • -1
    • +1
    ./Tasks/TaskPriority.c
2:29 pm

Sean Nash

DEN-9906: Fixed misc TBDs in comments.

Options
    • -5
    • +7
    ./Controllers/SyringePump.c
    • -2
    • +2
    ./Controllers/Voltages.c
    • -4
    • +4
    ./Modes/Dialysis.c
    • -2
    • +1
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Tasks/TaskGeneral.c
    • -1
    • +1
    ./Tasks/TaskPriority.c
1:40 pm

Sean Nash

What is the status of these commented out lines of code? Are we removing or keeping?

What is the status of these commented out lines of code? Are we removing or keeping?

1:39 pm

Sean Nash

What is the status of this line of code? Are we removing it or keeping it?

What is the status of this line of code? Are we removing it or keeping it?

1:38 pm

Sean Nash

Align comment.

Align comment.

1:38 pm

Sean Nash

Need to restore this code.

Need to restore this code.

1:37 pm

Sean Nash

Need to restore this code.

Need to restore this code.

1:37 pm

Sean Nash

Why do I not see a call to this function in SystemComm.c?

Why do I not see a call to this function in SystemComm.c?

1:34 pm

Sean Nash

Either testSetStopRTC() should return a BOOL and set result to that BOOL or you need to just set result to TRUE in this if scope - otherwise the Ack sent below will always be a Nak.

Either testSetStopRTC() should return a BOOL and set result to that BOOL or you need to just set result to TRUE in this if scope - otherwise the Ack sent below will always be a Nak.

Monday 08 Nov 2021
1:21 pm

Behrouz NematiPour

Saturday 06 Nov 2021
9:52 pm

Dara Navaei

DEN-9480 added stop RTC command

Options
    • -21
    • +0
    ./Controllers/BloodFlow.c
    • -19
    • +0
    ./Controllers/DialInFlow.c
    • -24
    • +0
    ./Services/SystemComm.c
    • -0
    • +22
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
7:04 pm

Dara Navaei

HD-DEN-9480_DG_DEV Dialysate Temperature Control
HD-DEN-9480_DG_DEV Dialysate Temperature Control
Friday 05 Nov 2021
7:09 pm

Behrouz NematiPour

I couldn't find TBD anywhere in the code!!! What is TBD?

I couldn't find TBD anywhere in the code!!!
What is TBD?

3:56 pm

Hung Nguyen <hnguyen@diality.com>

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

Options
    • -20
    • +10
    ./Controllers/DGInterface.c
    • -2
    • +1
    ./Controllers/DGInterface.h
    • -58
    • +13
    ./Controllers/DialInFlow.c
3:52 pm

Sean Nash

DEN-9906: Added more precision to dialysate flow filtering.

Options
    • -7
    • +7
    ./Controllers/DialInFlow.c
3:16 pm

Sean Nash

DEN-9906: Fixed bug w/ dialysate flow freshness alarm logic.

Options
    • -1
    • +3
    ./Controllers/DGInterface.c
1:51 pm

Sean Nash

DEN-9906: Minor changes to dialysate flow freshness alarm code.

Options
    • -20
    • +8
    ./Controllers/DGInterface.c
    • -2
    • +1
    ./Controllers/DGInterface.h
    • -52
    • +7
    ./Controllers/DialInFlow.c