hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 Nov 2021
10:06 am

Sean Nash

DEN-11114: perform periodic clock check only if release build so debugging will not cause alarm.

Options
    • -0
    • +2
    ./Services/FPGA.c
9:59 am

hnguyen  (deleted user)

Done.

Done.

9:57 am

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Removed signalDialOutPumpHardStop since it has not been started

Options
    • -1
    • +0
    ./Modes/Prime.c
9:51 am

Sean Nash

You can remove this line here. That pump has not yet been run.

You can remove this line here. That pump has not yet been run.

9:46 am

Sean Nash

DEN-11114: Removed obsolete UF PI controller. Cleaned up UF control code changes.

Options
    • -19
    • +15
    ./Controllers/DialOutFlow.c
    • -1
    • +0
    ./Services/PIControllers.c
    • -2
    • +1
    ./Services/PIControllers.h
9:34 am

Hung Nguyen <hnguyen@diality.com>

DEN-11089 the VDO pump is stopped before transition from dialyzer state to wet selftests state

Options
    • -0
    • +1
    ./Modes/Prime.c
9:30 am

hnguyen  (deleted user)

Fixed. Before transition from dialyzer state to wet selftests state, the VDO pump should be stopped.

Fixed. Before transition from dialyzer state to wet selftests state, the VDO pump should be stopped.

9:21 am

Sean Nash

Move this line to when prime dialyzer state is completed before we go to wet self tests.

Move this line to when prime dialyzer state is completed before we go to wet self tests.

Monday 22 Nov 2021
6:36 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Correction - dialyzer dialysate bypass priming path uses R1 instead of R2 and dialyzer dialysate priming path uses R2 instead of R1

Options
    • -7
    • +7
    ./HDCommon.h
    • -23
    • +24
    ./Modes/Prime.c
11:03 am

Sean Nash

DEN-11114: Added comment.

Options
    • -1
    • +1
    ./Controllers/DialOutFlow.c
Sunday 21 Nov 2021
4:22 pm

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

Options
    • -1
    • +16
    ./Modes/ModeTreatment.c
4:22 pm

Dara Navaei

DEN-11114 initial commit of the reservoirs module. Continued with implementing the reservoir management

Options
    • -19
    • +120
    ./Controllers/DGInterface.c
    • -3
    • +4
    ./Controllers/DGInterface.h
    • -0
    • +14
    ./Modes/Dialysis.c
    • -0
    • +1
    ./Modes/Dialysis.h
    • -3
    • +6
    ./Modes/ModeTreatment.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -0
    • +407
    ./Services/Reservoirs.c
    • -0
    • +38
    ./Services/Reservoirs.h
3:53 pm

Sean Nash

DEN-11114: Updated UF control to included estimated UF flow as input.

Options
    • -4
    • +5
    ./Controllers/DialInFlow.c
    • -40
    • +106
    ./Controllers/DialOutFlow.c
    • -0
    • +1
    ./Controllers/DialOutFlow.h
    • -1
    • +16
    ./Modes/ModeTreatment.c
    • -0
    • +1
    ./Modes/ModeTreatment.h
Friday 19 Nov 2021
10:23 am

Hung Nguyen <hnguyen@diality.com>

DEN-11089 Incorporated peer review comments

Options
    • -22
    • +15
    ./Modes/Prime.c
10:10 am

hnguyen  (deleted user)

Done

Done

10:07 am

hnguyen  (deleted user)

Fixed

Fixed

10:07 am

hnguyen  (deleted user)

I believe reservoir 2 is used. static PRE_TREATMENT_RESERVOIR_MGMT_STATE_T handlePreTreatmentReservoirMgmtStartState( void ) { PRE_TREATMENT_RESERVOIR_MGMT_STATE_T state = PRE_TREATMENT_RESERVOIR_...

I believe reservoir 2 is used.

static PRE_TREATMENT_RESERVOIR_MGMT_STATE_T handlePreTreatmentReservoirMgmtStartState( void )
{
PRE_TREATMENT_RESERVOIR_MGMT_STATE_T state = PRE_TREATMENT_RESERVOIR_MGMT_START_STATE;

if ( TRUE == fillReservoirOneStartRequested )

Unknown macro: { fillReservoirOneStartRequested = FALSE; state = PRE_TREATMENT_RESERVOIR_MGMT_DRAIN_CMD_STATE; cmdSetDGActiveReservoir( DG_RESERVOIR_2 ); }


return state;
}

10:04 am

hnguyen  (deleted user)

Fixed

Fixed

10:04 am

hnguyen  (deleted user)

Done

Done

10:04 am

hnguyen  (deleted user)

Done

Done

Thursday 18 Nov 2021
4:52 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
4:48 pm

Sean Nash

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
    • -1
    • +1
    ./Controllers/BloodFlow.c
    • -1
    • +1
    ./Controllers/DialInFlow.c
    • -1
    • +1
    ./Controllers/DialOutFlow.c
4:48 pm

Sean Nash

DEN-11114: Restored previous motor controller speed feedback conversion to RPM - it was right before.

Options
    • -1
    • +1
    ./Controllers/BloodFlow.c
    • -1
    • +1
    ./Controllers/DialInFlow.c
    • -1
    • +1
    ./Controllers/DialOutFlow.c
4:33 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
4:22 pm

Sean Nash

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
    • -6
    • +7
    ./Controllers/BloodFlow.c
    • -6
    • +8
    ./Controllers/DialInFlow.c
    • -4
    • +4
    ./Controllers/DialOutFlow.c
4:18 pm

Sean Nash

This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here.

This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here.

2:18 pm

Sean Nash

Why reset start time here?

Why reset start time here?

2:11 pm

Sean Nash

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path.

2:08 pm

Sean Nash

Make it clearer that this is for prime dialyzer state.

Make it clearer that this is for prime dialyzer state.

2:08 pm

Sean Nash

Dialyzer is spelled with a "z" not "s".

Dialyzer is spelled with a "z" not "s".