hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Aug 2023
1:09 pm

Sean Nash

Remove blank line.

Remove blank line.

1:08 pm

Sean Nash

Good catch. Consider replacing manual error timer counter with common persistence function.

Good catch. Consider replacing manual error timer counter with common persistence function.

1:02 pm

Sean Nash

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

Maybe create a public #define USE_SHORT_STABILIZATION_PERIOD TRUE somewhere in PresOccl.h to make these more readable.

1:01 pm

Sean Nash

Provide parameter name in prototype.

Provide parameter name in prototype.

1:00 pm

Sean Nash

This is a parameter, not an input.

This is a parameter, not an input.

12:57 pm

Sean Nash

Be explicit (i.e. TRUE == useShortStabilizeTime).

Be explicit (i.e. TRUE == useShortStabilizeTime).

12:57 pm

Sean Nash

Why set to false here? Seems like if statement in next state will always be false now.

Why set to false here? Seems like if statement in next state will always be false now.

12:54 pm

Sean Nash

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

This is a parameter, not an input - though there is a static variable that gets set by signal function, so not clear to me why you're not using that here instead of parameter.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

Rename function to name of state (like others).

Rename function to name of state (like others).

11:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:04 am

Dara Navaei

HD-DIAL-278_Fan Pwm Override
HD-DIAL-278_Fan Pwm Override
8:50 am

jtaylor  (deleted user)

Please check comment column alignment

Please check comment column alignment

Monday 21 Aug 2023
6:05 pm

Vinayakam Mani

Done.

Done.

6:04 pm

Vinayakam Mani

Done.

Done.

5:02 pm

jtaylor  (deleted user) and Michael Garthwaite

2:34 pm

Dara Navaei

HD-STT-2897_Bug Alarm 104 Alarm ID HD Air Trap Illegal Levels Triggers Before 2S
HD-STT-2897_Bug Alarm 104 Alarm ID HD Air Trap Illegal Levels Triggers Before 2S
1:45 pm

Sean Nash

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface tha...

Consider following up on this command's success once we're in complete state (would need to add a handler function for complete state). There is a getDGCommandResponse() function in DGInterface that we're using for other DG commands to make sure DG got and accepted the command (and sometimes retrying if not).

1:38 pm

Sean Nash

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

I think we have been trying to have these types of message IDs end in "_CMD_REQUEST".

12:35 pm

Michael Garthwaite

12:05 pm

Dara Navaei

HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
HD-DEN-16245_Hd.Valves.Cmd Set HD Valve Current Override Rejects Any Value
10:15 am

wbracken  (deleted user) and jtaylor  (deleted user)

9:54 am

jtaylor  (deleted user)

Friday 18 Aug 2023
4:57 pm

jtaylor  (deleted user)

4:47 pm

Sean Nash and wbracken  (deleted user)

12:04 pm

Dara Navaei

HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
11:03 am

Sean Nash

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:43 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!