hdfirmware / firmware

source

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 02 May 2024
2:06 pm

Vinayakam Mani

DEN-16851- HD stack optimization

Options
    • -5
    • +5
    ./sys_core.asm
    • -4
    • +4
    ./sys_link.cmd
  3. … 2 more files in changeset.
12:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:53 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:52 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:31 pm

Vinayakam Mani

Done.

Done.

12:31 pm

Vinayakam Mani

Done

Done

12:31 pm

Vinayakam Mani

Done

Done

12:30 pm

Vinayakam Mani

Done

Done

12:30 pm

Vinayakam Mani

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.

12:27 pm

Vinayakam Mani

Done.

Done.

12:27 pm

Vinayakam Mani

Done.

Done.

11:43 am

Sean Nash

I think we just want to publish the baseline here (not +1000).

I think we just want to publish the baseline here (not +1000).

11:42 am

Sean Nash

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32. You might want to cast the total as F32 as we...

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32.
You might want to cast the total as F32 as well for consistency.

11:39 am

Sean Nash

F32 not needed here.

F32 not needed here.

11:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:38 am

Sean Nash

Casting not necessary.

Casting not necessary.

11:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:35 am

Sean Nash

Are we guaranteed to be in Treatment mode here? If not, check mode too.

Are we guaranteed to be in Treatment mode here? If not, check mode too.

11:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:31 am

Sean Nash

Can stay U32.

Can stay U32.

11:30 am

Sean Nash

I think these can remain U32s. It's just when we divide total by count to get the filtered value, then we should have F32.

I think these can remain U32s. It's just when we divide total by count to get the filtered value, then we should have F32.

11:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:27 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:26 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:26 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.