hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Apr 2021
12:25 pm

Sean Nash

Merge branch 'DEN-7605-hd_dg_dev-self-tests' into develop

Options
    • -1
    • +1
    ./App/HDCommon.h
    • -0
    • +1
    ./App/Services/SystemCommMessages.c
12:25 pm

Sean Nash

DEN-7605: Added no minimize flag to alarm status message to UI.

Options
    • -1
    • +1
    ./App/HDCommon.h
    • -1
    • +9
    ./App/Services/AlarmMgmt.c
    • -0
    • +1
    ./App/Services/AlarmMgmt.h
    • -0
    • +1
    ./App/Services/SystemCommMessages.c
10:52 am

Sean Nash

There is only one state in this override message. It can be status or state (depending on message ID), but not both. Whichever it is, you are passing it to a function twice as if it is two differen...

There is only one state in this override message. It can be status or state (depending on message ID), but not both. Whichever it is, you are passing it to a function twice as if it is two different things. You need to revert back to having two override messages and two message handlers - one for status and one for state.

10:45 am

Sean Nash

So you combined the published data into one message in the publish function above which is correct. But these overrides must be separate. You should only override one thing at a time, so overrides ...

So you combined the published data into one message in the publish function above which is correct. But these overrides must be separate. You should only override one thing at a time, so overrides were ok as it was before.

10:31 am

qnguyen  (deleted user)

Need to add call to this function from task priority.

Need to add call to this function from task priority.

Thursday 08 Apr 2021
5:49 pm

Sean Nash

DEN-7605: Fixes per verification testing.

Options
    • -3
    • +3
    ./App/HDCommon.h
    • -0
    • +7
    ./App/Modes/Dialysis.c
    • -1
    • +1
    ./App/Modes/ModeTreatment.c
    • -1
    • +1
    ./App/Modes/Rinseback.c
    • -15
    • +10
    ./App/Modes/TreatmentStop.c
    • -1
    • +2
    ./App/Services/AlarmMgmt.c
5:02 pm

Sean Nash

lab testing fixes - will add to DEN-7605 dev branch.

Options
    • -3
    • +3
    ./App/HDCommon.h
    • -0
    • +7
    ./App/Modes/Dialysis.c
    • -1
    • +1
    ./App/Modes/ModeTreatment.c
    • -1
    • +1
    ./App/Modes/Rinseback.c
    • -15
    • +10
    ./App/Modes/TreatmentStop.c
3:17 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Removed Detector from names of functions

Options
    • -4
    • +4
    ./App/Services/SystemComm.c
    • -4
    • +4
    ./App/Services/SystemCommMessages.c
    • -4
    • +4
    ./App/Services/SystemCommMessages.h
3:01 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

3:00 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7395: Lumped Blood Leak Detector status and state into one published data

Options
    • -190
    • +52
    ./App/Controllers/BloodLeak.c
    • -10
    • +5
    ./App/Controllers/BloodLeak.h
    • -11
    • +4
    ./App/Services/SystemComm.c
    • -108
    • +18
    ./App/Services/SystemCommMessages.c
    • -15
    • +6
    ./App/Services/SystemCommMessages.h
2:59 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:21 pm

Sean Nash

Fixed merge conflicts.

Options
    • -69
    • +7
    ./App/Controllers/BloodFlow.c
    • -65
    • +6
    ./App/Controllers/DialInFlow.c
    • -3
    • +10
    ./App/Modes/ModePreTreat.c
    • -72
    • +97
    ./App/Modes/SelfTests.c
10:41 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Added build switch to skip empty reservoir check

Options
    • -0
    • +1
    ./App/HDCommon.h
    • -0
    • +6
    ./App/Modes/ModePostTreat.c
10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

Need to add state machine in this function. Call state handler functions from a switch statement.

Need to add state machine in this function. Call state handler functions from a switch statement.

10:31 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

Sean Nash

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

Preferred architecture is to just set flag here and then let your state machine see the flag and change the state and command the fpga when it next executes.

10:29 am

Sean Nash

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

10:28 am

qnguyen  (deleted user)

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.

getCurrentOperationMode() returns the current operation mode (standby, pre-treatment, treatment, post-treatment, etc.), not the sub-mode.

10:25 am

pmontazemi  (deleted user)

One is for the Blood Leak Detector status (blood leaked or blood not leaked), and the other one is for the Blood Leak Detector state of its state machine. This is just in case we wanted to have ind...

One is for the Blood Leak Detector status (blood leaked or blood not leaked), and the other one is for the Blood Leak Detector state of its state machine. This is just in case we wanted to have independent control over these time constants.

10:23 am

Sean Nash

But they could be packaged together into once blood leak data broadcast message.

But they could be packaged together into once blood leak data broadcast message.

10:20 am

Sean Nash

This is more of a request to run a self test by a mode (probably pre-treatment mode), so I think boolean is appropriate to indicate request was accepted.

This is more of a request to run a self test by a mode (probably pre-treatment mode), so I think boolean is appropriate to indicate request was accepted.

10:18 am

qnguyen  (deleted user)

Temperature values have been extracted out from treatment parameters in HD-DEN-7091.

Temperature values have been extracted out from treatment parameters in HD-DEN-7091.

10:15 am

Sean Nash

What is the difference between this interval override and the one below? If monitor is broadcasting 2 different messages, why? Recommend combining published blood leak data into one message.

What is the difference between this interval override and the one below? If monitor is broadcasting 2 different messages, why? Recommend combining published blood leak data into one message.

10:08 am

pmontazemi  (deleted user)

They publish two different values that can be set independently of each other.

They publish two different values that can be set independently of each other.

9:58 am

Dara Navaei

Can these two publish functions be lumped together?

Can these two publish functions be lumped together?

9:57 am

Dara Navaei

Usually the self tests return SELF_TEST_STATUS_T. Why does this function return a BOOL instead?

Usually the self tests return SELF_TEST_STATUS_T. Why does this function return a BOOL instead?

9:51 am

pmontazemi  (deleted user)

[~qnguyen] Please address.

[~qnguyen] Please address.

9:42 am

Dara Navaei

Recommend adding #defines for the temperature values.

Recommend adding #defines for the temperature values.