hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 17 Aug 2023
2:21 pm

Michael Garthwaite

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

1:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

wbracken  (deleted user)

Add dryPressureTestsCompleted to header.

Add dryPressureTestsCompleted to header.

1:01 pm

Sean Nash

12:56 pm

Michael Garthwaite

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

12:55 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:59 am

jtaylor  (deleted user)

9:10 am

Sean Nash

9:10 am

Sean Nash

8:35 am

Sean Nash

8:35 am

Sean Nash

8:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:22 am

jtaylor  (deleted user)

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

Wednesday 16 Aug 2023
4:42 pm

Sean Nash

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

3:34 pm

dcox  (deleted user)

3:28 pm

jtaylor  (deleted user)

Done.

Done.

3:27 pm

Sean Nash

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

3:26 pm

Sean Nash

Put constant on other side of comparison operator. We only put constant first when using "==".

Put constant on other side of comparison operator. We only put constant first when using "==".

3:14 pm

Sean Nash

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and...

This if will prevent countdown timer from being displayed unless we are paused or stopped after rinseback. I think countdown timer is definitely needed for rinseback init state (pump is stopped and rinseback hasn't even started). May be needed for new reconnect patient state as well.
I think it might be simpler/clearer to replace this if with a check for whether BP is running or not. If BP is stopped, we proceed to next if. If BP is running, keep timeouts at zero.

3:03 pm

Sean Nash

1:59 pm

dcox  (deleted user) , jtaylor  (deleted user) , wbracken  (deleted user) and Vinayakam Mani

1:51 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:04 pm

Dara Navaei

HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
HD-DEN-16164_FW Pre Treatment Pressure Test Failures Vent TO Saline Bag
10:35 am

Dara Navaei

10:34 am

Vinayakam Mani , jtaylor  (deleted user) , wbracken  (deleted user) , Michael Garthwaite and Sean Nash

10:25 am

jtaylor  (deleted user)

10:14 am

Sean Nash

10:10 am

Dara Navaei

HD-DEN-16239_Add A Test Configuration TO Disable Blood Leak Alarm
HD-DEN-16239_Add A Test Configuration TO Disable Blood Leak Alarm
9:11 am

Michael Garthwaite

9:02 am

Sean Nash

Done.

Done.