Activity hdfirmware/firmware

11:39 am

Vinayakam Mani and Dara Navaei

More
HD-DEN-16519-2
finished reviewing

11:32 am

Vinayakam Mani and Dara Navaei

More
HD-DEN-16519-1
finished reviewing

11:10 am

Michael Garthwaite and Sean Nash

More
HD-DEN-16518-1
finished reviewing

11:10 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

11:04 am

Vinayakam Mani

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

11:03 am

Vinayakam Mani

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

10:42 am

Sean Nash

Do we want to have the 11% minimum here? I thought it was just for closed loop control.

10:27 am

Michael Garthwaite

More
Re: HD-DEN-16518-1
commented on review

This will cause open loop control mode to have a minimum of 11% instead of 10%. For open loop, pwmDC is assigned a value at line 295. Do we still need the #define for the 10% pwm lower limit?

1:18 pm

Dara Navaei

More
HD-DEN-16519-2
started review

HD-DEN-16519_Pressure Window Adjustments DO Not Reset After New Treatment

1:18 pm

Dara Navaei

More
HD-DEN-16519-1
started review

HD-DEN-16519_Pressure Window Adjustments DO Not Reset After New Treatment

10:53 am

Dara Navaei and Sean Nash

More
HD-DEN-16595-1
finished reviewing

8:11 pm

Dara Navaei and Sean Nash

More
HD-DEN-16595-2
finished reviewing

8:11 pm

Dara Navaei

RESOLVED in CODE WALKTHROUGH

1:04 pm

The removed code changes are dead code due to condition of "if" condition check at top level ( ALARM_TABLE[ a ].alarmClearOnly). these alarms have property of 'clear only' as 'TRUE" in the alarm ta...

The removed code changes are dead code due to condition of "if" condition check at top level ( ALARM_TABLE[ a ].alarmClearOnly). these alarms have property of 'clear only' as 'TRUE" in the alarm table. hence condition always be false and the removed code changes never executed.

8:59 am