Activity hdfirmware/results/Build_Status

9:33 am

Sean Nash and Dara Navaei

More
HD-UCOMMITS-28
finished reviewing

9:21 am

Dara Navaei

More
HD-UCOMMITS-28
started review

HD Staging Unreviewed Commits

9:18 am

Dara Navaei

More
e254c20
changed 2 files
DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 104 more HD-UCOMMITS-28

Renamed some of the VectorCAST modules to be able to generate the html reports for them. Updated the .gitignore for the reuslts folder to ignore all the results folders

- -8
- +0
./Build_Status_Report.csv
- History
- Source
- Diff
./Build_Status_Report.csv
… 1 more file in changeset.

3:18 pm

jtaylor (deleted user) , wbracken (deleted user) and Sean Nash

More
HD-DENBUG-116-1
finished reviewing

12:32 pm

Dara Navaei

DENBUG-116 updated the VectorCAST test cases

- -11
- +3
./Build_Status_Report.csv
- History
- Source
- Diff
./Build_Status_Report.csv

11:20 am

Dara Navaei

More
HD-DENBUG-116-1
started review

HD-DENBUG-116_DG Allows Update OF Calibration Service System Records IN Other Modes Besides

9:23 am

Sean Nash

More
HD-DEN-16446-2
finished reviewing

4:37 pm

wbracken (deleted user)

More
HD-DEN-16446-2
finished reviewing

4:36 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

2:23 pm

Dara Navaei

More
Re: HD-DEN-16446-2
replied to wbracken (deleted user)

The result will be an unsigned integer

2:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:37 pm

Vinayakam Mani

More
Re: HD-DEN-16446-2
replied to Sean Nash

In the If conditions, we check "uFVolume > colUFVol" conditions, that makes uFRate always positive and hence the condition for minimum check is not required.

11:41 am

Dara Navaei

DEN-16446 updated the VectorCAST test cases

- -1
- +13
./Build_Status_Report.csv
- History
- Source
- Diff
./Build_Status_Report.csv

3:00 pm

jtaylor (deleted user)

More
HD-DEN-16446-2
resumed reviewing

2:59 pm

Dara Navaei

More
c96f3fe
changed 5 files
DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped, DEN-15953-dialysate-temp-alarm-triggered-after-dialysate-recirculation-stopped-2 and 106 more HD-DEN-16446-2

DEN-16446 updated the VectorCAST test cases

- -218
- +2
./Build_Status_Report.csv
- History
- Source
- Diff
./Build_Status_Report.csv
… 4 more files in changeset.

11:05 am

Sean Nash

More
Re: HD-DEN-16446-2
commented on review

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which i...

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which is < 0.0.

10:42 am