Activity leahi-application/sources/gui/qml/pages/settings

Tree
Accordion

Stats

Commits this week: 9

Total Committers:	6
Last Commit:	20 Aug
Commits this week:	9

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 20 Aug

4:58 pm

Nicholas Ramirez

More
0404b2d
changed 23 files
feature/LDT-5586-Heat-Disinfect LEAHI-APPLICATION-LDT-5586-1

LDT-5589 Disinfection - SW - 01- Heat Disinfect - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

update message id and remove obsoelte disinfect items

- -7
- +7
./SettingsDGCleaning.qml
- History
- Source
- Diff
./SettingsDGCleaning.qml
… 22 more files in changeset.

3:22 pm

Nicholas Ramirez

bn approves

bn approves

3:21 pm

Nicholas Ramirez

BN approvo

BN approvo

1:33 pm

Nicholas Ramirez

More
dbe55da
changed 13 files
develop

Merge branch 'feature/LDT-5158-integration-calibration' into develop

- -6
- +25
./SettingsCalibrationSettings.qml
- History
- Source
- Diff
./SettingsCalibrationSettings.qml
- -1
- +1
./SettingsStack.qml
- History
- Source
- Diff
./SettingsStack.qml
… 11 more files in changeset.

10:03 am

Dara Navaei

More
LEAHI-APPLICATION-LDT-5586-1
started review

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I

9:00 am

Nicholas Ramirez

More
03fc094
changed 2 files
feature/LDT-5572-calibration-Hydraulics LEAHI-APPLICATION-LDT-5572-1

LDT-5575 Service - SW - 01- Calibration - Hydraulics - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

fixed unit for pu0p rate

- -15
- +14
./servicemode/ServiceModeHydraulics.qml
- History
- Source
- Diff
./servicemode/ServiceModeHydraulics.qml
… 1 more file in changeset.

8:59 am

Dara Navaei

Wednesday 19 Aug

9:24 pm

Dara Navaei , Tiffany Mejia , Stephen Quong and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-5618-1
finished reviewing

8:07 pm

Behrouz NematiPour

More
LEAHI-APPLICATION-LDT-5618-1
started review

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

4:50 pm

Nicholas Ramirez

More
3082da7
changed 6 files
feature/LDT-5572-calibration-Hydraulics LEAHI-APPLICATION-LDT-5572-1

LDT-5575 Service - SW - 01- Calibration - Hydraulics - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

qml competed

- -36
- +145
./servicemode/ServiceModeHydraulics.qml
- History
- Source
- Diff
./servicemode/ServiceModeHydraulics.qml
… 5 more files in changeset.

4:21 pm

Behrouz NematiPour

3:05 pm

Behrouz NematiPour

More
60f7e69
changed 17 files
LDT-5485-sw-misc-enhc---sw---01--asn---iso-uf, LDT-5618-sw-misc-enhc-sw-board-freeze and 6 more LEAHI-APPLICATION-LDT-5618-1 LEAHI-APPLICATION-LDT-5104-14

Removing the layers and dropshadow and the diagnostics screen

- -12
- +12
./SettingsAdvancedInstitutional.qml
- History
- Source
- Diff
./SettingsAdvancedInstitutional.qml
- -12
- +12
./SettingsCalibrationSettings.qml
- History
- Source
- Diff
./SettingsCalibrationSettings.qml
- -12
- +12
./SettingsInstitutionalRecord.qml
- History
- Source
- Diff
./SettingsInstitutionalRecord.qml
… 14 more files in changeset.

3:04 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-5618-1
started review

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C

2:05 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-5572-1
started review

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I

LEAHI-APPLICATION-LDT-5572_Service - SW - 01- Calibration - Hydraulics - R&I

1:55 pm

Nicholas Ramirez

More
2fc8114
changed 9 files
feature/LDT-5572-calibration-Hydraulics LEAHI-APPLICATION-LDT-5572-1

LDT-5575 Service - SW - 01- Calibration - Hydraulics - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

add pages for service mode and hydraulics

- -1
- +1
./SettingsBase.qml
- History
- Source
- Diff
./SettingsBase.qml
- -0
- +1
./SettingsHome.qml
- History
- Source
- Diff
./SettingsHome.qml
- -0
- +28
./SettingsServiceModeStack.qml
- History
- Source
./SettingsServiceModeStack.qml
- -21
- +35
./SettingsStack.qml
- History
- Source
- Diff
./SettingsStack.qml
- -0
- +130
./servicemode/ServiceModeHydraulics.qml
- History
- Source
./servicemode/ServiceModeHydraulics.qml
- -0
- +99
./servicemode/ServiceModeMainMenu.qml
- History
- Source
./servicemode/ServiceModeMainMenu.qml
… 3 more files in changeset.

1:51 pm

Nicholas Ramirez

updated

updated

12:49 pm

Behrouz NematiPour

APPROVED.

APPROVED.

12:49 pm

Behrouz NematiPour

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

12:48 pm

Behrouz NematiPour

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
Also move the:
```
; if ( ! ok ) { goto invalid; }
```
on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

12:40 pm

Behrouz NematiPour

APPROVED

APPROVED

Tuesday 18 Aug

4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

4:24 pm

Nicholas Ramirez

updated

updated

3:35 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

3:34 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

3:17 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-5158-1
commented on review

double check

double check

3:04 pm

Nicholas Ramirez

Monday 17 Aug

5:03 pm

Sean Nash

More
LEAHI-APPLICATION-LDT-5158-1
left review

4:04 pm

Nicholas Ramirez

More
d560d60
changed 3 files
develop, feature/LDT-5158-integration-calibration LEAHI-APPLICATION-LDT-5158-1

LDT-5163 SW Misc & Enhc - SW - 01 - SW Integration - Calibration - R&I - 05: DEV - Feature Implementation

fina lbug fixes with sim

- -1
- +1
./SettingsCalibrationSettings.qml
- History
- Source
- Diff
./SettingsCalibrationSettings.qml
… 2 more files in changeset.

11:15 am

Nicholas Ramirez

More
5538544
changed 2 files
develop, feature/LDT-5158-integration-calibration LEAHI-APPLICATION-LDT-5158-1

add defaut rejection list to all models

- -1
- +0
./SettingsCalibrationSettings.qml
- History
- Source
- Diff
./SettingsCalibrationSettings.qml
… 1 more file in changeset.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-08-21 02:19 -0700