MAlarmMapping.cpp

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-5589 Disinfection - SW - 01- Heat Disinfect - R&I - 03: DEV - Feature Implementation & Code Document [& Diagnostics]

update message id and remove obsoelte disinfect items

  1. … 22 more files in changeset.
push alarms

  1. … 2 more files in changeset.
bn approves

bn approves

BN approvo

BN approvo

LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I
LEAHI-APPLICATION-LDT-5586_Disinfection - SW - 01- Heat Disinfect - R&I
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
Updated the Alarm Mapping with the staging.

  1. … 4 more files in changeset.
Adding Alarm Mapping, since the automation is now disabled for migrations.

  1. … 4 more files in changeset.
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
LEAHI-APPLICATION-LDT-5618_SW Misc & Enhc - SW - Board Freeze - I&C
updated

updated

APPROVED.

APPROVED.

RESOLVED. Added another comment regarding the same.

RESOLVED.
Added another comment regarding the same.

Nicholas Ramirez Thanks for the change to the ok and result. *To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the fun...

Nicholas Ramirez
Thanks for the change to the ok and result.

  • To be consistent, could you please use ok instead of result, since all the other parts of the code use ok as an argument, and the function itself has ok as the parameter name.
  • Also move the:
    ; if ( ! ok ) { goto invalid; }
    

    on the "same line" and "aligned" as the evaluating parameter, to keep the code clean.

APPROVED

APPROVED

updated

updated

updated

updated

updated

updated

remove the ok and just check result and if any fails goto invalid

remove the ok and just check result and if any fails goto invalid

see if you can use payloadLen from MessageGlobals.h

see if you can use payloadLen from MessageGlobals.h

double check

double check

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

removedin https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-5331-1CFR-87504

Resolved conflict with the remote

  1. … 4 more files in changeset.
Adding AlarmMapping for now for the develop.

  1. … 2 more files in changeset.
remove from prime // priming - TODO check if needed. may not need

remove from prime // priming - TODO check if needed. may not need