Activity leahi-application/sources/view/settings/VAdjustmentVersions.cpp

3:06 pm

Tiffany Mejia

3:03 pm

Stephen Quong and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-926-1
finished reviewing

2:09 pm

Stephen Quong

RESOLVED

3:28 pm

Nicholas Ramirez

RESOLVED

3:23 pm

Tiffany Mejia

fixed, thanks!

3:07 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

this looks like this will error.. Should be title: qsTr("Treatment Delivery & Blood Handling")

this looks like this will error.. Should be

    title: qsTr("Treatment Delivery & Blood Handling")

3:04 pm

Nicholas Ramirez

RESOLVED

1:49 pm

Tiffany Mejia

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

Understood, will consider in a future story to adjust all models

1:48 pm

Tiffany Mejia

addressed

9:56 am

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible. (https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible.
(https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

4:51 pm

Stephen Quong

More
LEAHI-APPLICATION-LDT-926-1
joined review

1:43 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

probably do not need to translate because its a diagnostics page but to keep consistent with all other user facing texts in this file please translate.

9:44 pm